Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go test #2076

Closed
wants to merge 17 commits into from
Closed

Update go test #2076

wants to merge 17 commits into from

Conversation

dingxiaoshuai123
Copy link
Collaborator

update a part of go test. #2046
filename : server_test.go


num2 := client2.Do(ctx, "pubsub", "numpat")
Expect(num2.Err()).NotTo(HaveOccurred())
Expect(num2.Val()).To(Equal(int64(1)))
defer func() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为何要挪下来?

import (
"context"
"fmt"
. "github.com/bsm/ginkgo/v2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这顺序写的太乱了,问下 yuecai,规整下


var _ = FDescribe("shuould replication ", func() {
Describe("all replication test", func() {
// 在这里定义两个连接
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全 PR 不要使用中文,全部转成英文

@@ -11,46 +11,65 @@ import (
"time"
)

func cleanEnv(ctx context.Context, clientSlave *redis.Client, clientMaster *redis.Client) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clientSlave *redis.Client, clientMaster *redis.Client --> clientMaster, clientSlave *redis.Client

@dingxiaoshuai123 dingxiaoshuai123 closed this by deleting the head repository Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants