fix issue 2096: The setrange and setbit commands do not retain the expiration time of the original key #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for your contribution to our project. what's more, would you please submit an issue firstly to explain what's the problem? |
u6th9d
changed the title
AlexStocks
changed the title
|
I have combine this pr with the issue 2096. And then, would you be pleased to add some tests in Golang for your code? |
AlexStocks
approved these changes
Nov 3, 2023
dingxiaoshuai123
approved these changes
Nov 4, 2023
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
…piration time of the original key (OpenAtomFoundation#2095) * fix setrange/bitop cmd lost key expire time * Update string_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #2096