Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean-dir tcl #2507

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

Mixficsol
Copy link
Collaborator

@Mixficsol Mixficsol commented Mar 13, 2024

在执行 ./pikatest.shTCL 测试的时候,测试过程中产生的数据会存放在相应的文件夹下面,如果你希望在测试完之后立即删除文件夹,可以把 cleanup 注释打开,大多数时候在测试过程中发现了问题,我们需要在指定文件夹下面进行问题追溯,所以默认情况下 cleanup 是注释掉的,为了区分测试建立的文件夹和平常使用 Pika 是建立的 DB 文件夹,在 TCL 测试中建立的文件夹后面接了数字,例如 db10233, 所以删除这部分文件夹的时候使用的通配符避免误删了正常使用 PikaDB 文件夹

When running the TCL test, the data generated during the test will be stored in the corresponding folder. If you want to delete the temporary folder generated by the test immediately after the test is finished, you can use './pikatest.sh all clean '. Add a clean parameter, most of the time problems are found in the test process, we need to trace the problem under the specified folder, in order to distinguish the folder created in the test and the DB folder created by ordinary Pika, the folder created in the TCL test is followed by a number. For example, db10233, so the wildcard character used when deleting this part of the folder to avoid accidentally deleting the DB folder that normally uses Pika

fix: #2454

@machinly
Copy link
Collaborator

建议加一个参数控制是否清理,而不是修改脚本。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


It is recommended to add a parameter to control whether to clean or not, rather than modifying the script.

@Mixficsol
Copy link
Collaborator Author

建议加一个参数控制是否清理,而不是修改脚本。

done

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


It is recommended to add a parameter to control whether to clean or not, rather than modifying the script.

done

@chejinge chejinge self-requested a review March 13, 2024 09:04
@AlexStocks AlexStocks merged commit cacd576 into OpenAtomFoundation:unstable Mar 14, 2024
13 checks passed
@Mixficsol Mixficsol deleted the clean-dir branch March 14, 2024 12:16
chejinge pushed a commit that referenced this pull request Apr 17, 2024
Co-authored-by: wuxianrong <wuxianrong@360.cn>
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
Co-authored-by: wuxianrong <wuxianrong@360.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.5.4 ☢️ Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear discarded files generated after TCL testing
5 participants