Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flushdb and flushall bug #2533

Merged
merged 5 commits into from
Mar 29, 2024
Merged

fix: flushdb and flushall bug #2533

merged 5 commits into from
Mar 29, 2024

Conversation

Mixficsol
Copy link
Collaborator

@Mixficsol Mixficsol commented Mar 19, 2024 •
edited

  1. 重写了 Flushall 命令的写 Binlog 逻辑 （由之前的写多条FlushDB 记录改成写一条 Flushall记录）
  2. 将 Flushall， FlushDB , Info, config, shutdown, Exec, Watch 命令逻辑由 Execute() 改成了 Do()
  3. 修复了由于 【主从同步待修复】pika中一次操作flushdb等管理命令，有写性质的命令，由于binlog处理不当，可能引起主从不一致 #2526 这个原因导致的测试时主从数据不一致的问题，相应的修改了 Replication 的测试
  4. 修复了 Flushall 和 FlushDB 中有一处由于加锁顺序的问题导致死锁的隐患
  5. 删除了 FlushSubDB 接口

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Mar 19, 2024
@Mixficsol Mixficsol removed the 3.5.4 label Mar 20, 2024
@Mixficsol Mixficsol marked this pull request as ready for review March 22, 2024 08:02
@Mixficsol Mixficsol changed the title fix: flushdb bug fix: flushdb and flushall bug Mar 22, 2024
@Mixficsol Mixficsol added the wip Work in Progress (PR incomplete - needs more work or rework) label Mar 25, 2024
@Mixficsol Mixficsol removed the wip Work in Progress (PR incomplete - needs more work or rework) label Mar 25, 2024
chejinge
chejinge reviewed Mar 29, 2024
View reviewed changes
src/pika_admin.cc Outdated Show resolved Hide resolved
@Mixficsol Mixficsol merged commit a378bd1 into OpenAtomFoundation:unstable Mar 29, 2024
11 of 12 checks passed
chejinge pushed a commit that referenced this pull request Apr 8, 2024
@Mixficsol @brother-jin
fix: flushdb and flushall bug (#2533)
bf5e97c 
* fix flushdb bug
* Updated flushall write Binlog logic
* delete flushsubdb
* add flushall cache clear

---------
@Mixficsol Mixficsol deleted the fix_flushdb branch May 23, 2024 06:45
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
@Mixficsol
fix: flushdb and flushall bug (OpenAtomFoundation#2533)
8371204 
* fix flushdb bug
* Updated flushall write Binlog logic
* delete flushsubdb
* add flushall cache clear

---------

Co-authored-by: Mixficsol <838844609@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@dingxiaoshuai123 dingxiaoshuai123 dingxiaoshuai123 approved these changes

@chejinge chejinge chejinge approved these changes

Assignees
No one assigned
Labels
3.5.4 4.0.0 ☢️ Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mixficsol @AlexStocks @dingxiaoshuai123 @chejinge