slave thread pool #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loveyacper
reviewed
Oct 11, 2023
| @@ -85,9 +85,15 @@ class EventLoop { | |||
| // for unittest only | |||
| void Reset(); | |||
|
|
|||
| std::shared_ptr<EventObject> GetEventObject(int id){ return objects_[id]; } | |||
loveyacper
reviewed
Oct 11, 2023
| @@ -85,9 +85,15 @@ class EventLoop { | |||
| // for unittest only | |||
| void Reset(); | |||
|
|
|||
| std::shared_ptr<EventObject> GetEventObject(int id){ return objects_[id]; } | |||
| bool IsSlaveEventLoop(){ return name_.find("slave") != std::string::npos; } | |||
There was a problem hiding this comment.
待评估吧，把业务逻辑加到eventloop这样的底层类，不是太妥。
lqxhub
reviewed
Oct 11, 2023
| @@ -85,9 +85,15 @@ class EventLoop { | |||
| // for unittest only | |||
| void Reset(); | |||
|
|
|||
| std::shared_ptr<EventObject> GetEventObject(int id){ return objects_[id]; } | |||
There was a problem hiding this comment.
objects_[id] 这种方式获取 map内的数据, 如果map中没有这个id的数据, 会插入一条key 为这个id的数据, 所以在获取map数据时, 不要使用 objects_[id] 这种方式
loveyacper
reviewed
Oct 11, 2023
| @@ -102,26 +106,29 @@ EventLoop* EventLoop::Self() { return g_this_loop; } | |||
| bool EventLoop::Register(std::shared_ptr<EventObject> obj, int events) { | |||
| if (!obj) return false; | |||
|
|
|||
| assert(InThisLoop()); | |||
| // assert(InThisLoop()); | |||
There was a problem hiding this comment.
这个在进行TcpConnection从一个loop转移到另一个slave_loop时，会存在跨线程注册，这里对objects_作加锁保护了
loveyacper
reviewed
Oct 11, 2023
AlexStocks
reviewed
Oct 11, 2023
| } while (id < 0 || objects_.count(id) != 0); | ||
| { | ||
| // alloc unique id | ||
| std::unique_lock<std::mutex> guard(object_mutex_); |
There was a problem hiding this comment.
这行代码可以挪到 line 127 之下，以缩小 lock scope。毕竟119-125是原子操作。
There was a problem hiding this comment.
125行有对objects_进行访问，不应需要在while循环之前加锁么
|
The slave thread pool has resubmitted a new pr that fixes some of the previous irregularities |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add lock