Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No check on landline phone numbers in the players edition form #515

Closed
yassine-ouaamou opened this issue Jan 11, 2024 · 1 comment · Fixed by #575
Closed

No check on landline phone numbers in the players edition form #515

yassine-ouaamou opened this issue Jan 11, 2024 · 1 comment · Fixed by #575
Assignees
Labels
bug use for describing something not working as expected solved The issue has been solved
Milestone

Comments

@yassine-ouaamou
Copy link
Member

Description

There is no check for the phone number (fix) field in the players edition form

Environment

Environment details: Testing

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. Edit a player
  2. Put a random text in the field Phone number (fix)
  3. Save

Expected Output

A check like for Phone number (mobile)

Actual Output

No check. We can put any kind of content

Additional information

It is usually called landline instead of fix: Phone number (landline)

Screenshots (optional)

image

@yassine-ouaamou yassine-ouaamou added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Jan 11, 2024
@yassine-ouaamou
Copy link
Member Author

I just noticed that the only validation we do on the mobile phone number field is that it starts with a “+”. This means we can enter any text after the “+” character.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved The issue has been solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants