New functionality for UK Sold house price data

[kulbinderdio]

Description

• [ New functionality under Alternative to retrieve UK sold house price data] Summary of the change / bug fix.
• Link # issue, if applicable.
• [

] Screenshot of the feature or the bug before/after fix, if applicable. - [ ] Relevant motivation and context. - [ SPARQLWrapper] List any dependencies that are required for this change.

How has this been tested?

• Please describe the tests that you ran to verify your changes.
  Have ran all commands from application and also created a test class
• Provide instructions so we can reproduce.
• Please also list any relevant details for your test configuration.

• Make sure affected commands still run in terminal
• Ensure the SDK still works
• Check any related reports

Checklist:

• Update our Hugo documentation following these guidelines.
• Update our tests following these guidelines.
• Make sure you are following our CONTRIBUTING guidelines.
• If a feature was added make sure to add it to the corresponding scripts file.

Others

• [ x] I have performed a self-review of my own code.
• [ x] I have commented my code, particularly in hard-to-understand areas.

[kulbinderdio]

Hi, is there something else required for me to do now?

[jmaslek]

Sorry for the long delay. Will go through now.

First thing I see is that in the menu:

│                                                                                                                                      │
│     sales              list UK house sales via postcode                                                                              │
│                                                                                                                                      │
│ alternative/realestate/_postcode:                                                                                                    │
│                                                                                                                                      │
│     townsales          list UK house sales via town                                                                                  │
│                                                                                                                                      │
│ alternative/realestate/_town:                                                                                                        │
│ alternative/realestate/_startdate <YYYY-MM-DD>:                                                                                      │
│ alternative/realestate/_enddate <YYYY-MM-DD>:                                                                                        │
│                                                                                                                                      │
│     regionstats        retrieve UK sold house price stats by region                                                                  │
│                                                                                                                                      │
│ alternative/realestate/_region:                                                                                                      │
│ alternative/realestate/_startdate <YYYY-MM-DD>:                                                                                      │
│ alternative/realestate/_enddate <YYYY-MM-DD>:        

Looks like you are missing the entries for the _town/_start etc in the i18 file.

[jmaslek]

This doesn't need to be here. This triggers the select valid postcode.

[jmaslek]

If i look for help :

2023 Jan 25, 20:27 (🦋) /alternative/realestate/ $ sales -h

usage: sales [-p postcode] [-h] [--export EXPORT] [--sheet-name SHEET_NAME [SHEET_NAME ...]]

Select the postcode you want to see sold house price data for. [Source: UK Land Registry]

optional arguments:
  -p postcode, --postcode postcode
                        Postcode (default: None)
  -h, --help            show this help message (default: False)
  --export EXPORT       Export raw data into csv, json, xlsx (default: )
  --sheet-name SHEET_NAME [SHEET_NAME ...]
                        Name of excel sheet to save data to. Only valid for .xlsx files. (default: None)

For more information and examples, use 'about sales' to access the related guide.

Select valid postcode

The select valid postcode shouldnt appear if we have the -h flag. I pointed out where this happens in the code

[jmaslek]

If i look for help :

2023 Jan 25, 20:27 (🦋) /alternative/realestate/ $ sales -h

usage: sales [-p postcode] [-h] [--export EXPORT] [--sheet-name SHEET_NAME [SHEET_NAME ...]]

Select the postcode you want to see sold house price data for. [Source: UK Land Registry]

optional arguments:
  -p postcode, --postcode postcode
                        Postcode (default: None)
  -h, --help            show this help message (default: False)
  --export EXPORT       Export raw data into csv, json, xlsx (default: )
  --sheet-name SHEET_NAME [SHEET_NAME ...]
                        Name of excel sheet to save data to. Only valid for .xlsx files. (default: None)

For more information and examples, use 'about sales' to access the related guide.

Select valid postcode

The select valid postcode shouldnt appear if we have the -h flag. I pointed out where this happens in the code

If i look for help :

2023 Jan 25, 20:27 (🦋) /alternative/realestate/ $ sales -h

usage: sales [-p postcode] [-h] [--export EXPORT] [--sheet-name SHEET_NAME [SHEET_NAME ...]]

Select the postcode you want to see sold house price data for. [Source: UK Land Registry]

optional arguments:
  -p postcode, --postcode postcode
                        Postcode (default: None)
  -h, --help            show this help message (default: False)
  --export EXPORT       Export raw data into csv, json, xlsx (default: )
  --sheet-name SHEET_NAME [SHEET_NAME ...]
                        Name of excel sheet to save data to. Only valid for .xlsx files. (default: None)

For more information and examples, use 'about sales' to access the related guide.

Select valid postcode

The select valid postcode shouldnt appear if we have the -h flag. I pointed out where this happens in the code

This happens for all other functions.

[jmaslek]

These functions should have a limit in the views. For example, I run townsales -t London -s 2022-01-01 -e 2022-01-10 and it populated my whole IDE.

additionally, we probably want to specify a default start and end date (if I do townsales -t London it should work, but it currently does not)

[kulbinderdio]

default limit values added to model functions.

[kulbinderdio]

I just applied a branch update and now I'm getting Linting errors in my controller that is a new file but was formatted ok prior to the branch update. Since the file is new and only in my pull request don't understand why it is failing now

[jmaslek]

I just applied a branch update and now I'm getting Linting errors in my controller that is a new file but was formatted ok prior to the branch update. Since the file is new and only in my pull request don't understand why it is failing now

The black formatter published a new version last night, which is what gets installed on the linter. You can locally run pip install -U black then reformat to fix

[kulbinderdio]

Reviewpad failed with the error API rate limit exceeded for installation ID 30911239.

[jmaslek]

Sorry for the delay. Was busy getting that last release fixed. If you fix the merge conflicts, I will give a final look today!

[kulbinderdio]

Have resolved merge issues but now failing on some security checks I haven't seen before to do with Snyk.

[jmaslek]

Something is still not correct with the poetry lock.The unit test check is failing on install dependencies.

poetry export -f requirements.txt -E optimization --without-hashes --output requirements.txt
poetry export -f requirements.txt --dev -E all --without-hashes --output requirements-full.txt

[kulbinderdio]

I ran the poetry export commands and can't see any install errors but can see that some of not tests were skipped. Not sure how to resolve.

[jmaslek]

I ran the poetry export commands and can't see any install errors but can see that some of not tests were skipped. Not sure how to resolve.

ill take a stab at

[jmaslek]

I ran the poetry export commands and can't see any install errors but can see that some of not tests were skipped. Not sure how to resolve.

Everything was good on the update. Not sure what the snyk issues are, but I can ignore them for now. I just added a test script for our end and the rest looks good!

[jmaslek]

Thanks for your patience!

[kulbinderdio]

No problem. I know you're busy.
Thanks a lot for your help. Been over a decade since I last worked on a large multi developer project.