-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/options screener fix #4335
Conversation
sdk was not properly generated: You need to run Doing this results in errors (AttributeError: module 'openbb_terminal.common.technical_analysis.volatility_model' has no attribute 'rvol_hodges_tompkins'). Theres also an extra trailing , in economy.cpi that needs to be taken out to get the above error. |
i gotchu |
Now what's up with the tests? :( |
|
||
MODELS = volatility_model.VOLATILITY_MODELS | ||
MOCK_DATA = pd.read_csv( | ||
"tests/openbb_terminal/stocks/technical_analysis/csv/test_volatility_model/test_cones_df.csv", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break on windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which part breaks on Windows? Does it need to be called, MOCK_STOCK_DF
?
from test_ta_controller.py
:
MOCK_STOCK_DF = pd.read_csv(
"tests/openbb_terminal/stocks/technical_analysis/csv/test_ta_controller/stock_df.csv",
index_col=0,
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
windows doesnt read /
. Im fixing
idk. looking. Also have no idea what you did to generate 200 test changes with newlines at the end |
…BB-finance/OpenBBTerminal into hotfix/options-screener-fix
This patch is for #4250
Done: