Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate chart #4511

Merged
merged 8 commits into from
Mar 17, 2023
Merged

Removed duplicate chart #4511

merged 8 commits into from
Mar 17, 2023

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Mar 17, 2023

Description

Fixes #3442

Stops showing the old, hard to read, chart. Only shows the new one with dual axises.

How has this been tested?

economy/index --indices sp500,cboe_vix -s 2022-10-10/plot --y1 sp500 --y2 cboe_vix

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@4ea20eb). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4511   +/-   ##
==========================================
  Coverage           ?   54.54%           
==========================================
  Files              ?      584           
  Lines              ?    52653           
  Branches           ?        0           
==========================================
  Hits               ?    28722           
  Misses             ?    23931           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@colin99d colin99d added this pull request to the merge queue Mar 17, 2023
@colin99d colin99d removed this pull request from the merge queue due to a manual request Mar 17, 2023
@colin99d colin99d added the do not merge Label to prevent pull request merge label Mar 17, 2023
@tehcoderer tehcoderer removed the do not merge Label to prevent pull request merge label Mar 17, 2023
@tehcoderer
Copy link
Contributor

It's truly fixed now🤣... They had the view inside of the iterate loop in the controller🤦‍♂️.

Improved the controller and view overall. 😘🥰🚀

@colin99d colin99d enabled auto-merge March 17, 2023 15:18
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat XS Extra small feature labels Mar 17, 2023
@colin99d colin99d added this pull request to the merge queue Mar 17, 2023
@colin99d colin99d merged commit 84a3628 into develop Mar 17, 2023
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
* Removed duplicate chart

* Removed duplicate chart

* improved and fixed `call_index` in economy controller

* Update preferences_model.py

* Improve handling for dot in ticker

---------

Co-authored-by: teh_coderer <me@tehcoderer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] economy single line with plot
3 participants