Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/fix-fmp-market-snapshots - make fields optional again. #5686

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Hotfix/fix-fmp-market-snapshots - make fields optional again. #5686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions openbb_platform/providers/fmp/openbb_fmp/models/market_snapshots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ class FMPMarketSnapshotsData(MarketSnapshotsData):
"change_percent": "changesPercentage",
}

name: str = Field(
description="The name associated with the stock symbol.", default=None
)
price: Optional[float] = Field(
description="The last price of the stock.", default=None
)
Expand All @@ -54,17 +51,19 @@ class FMPMarketSnapshotsData(MarketSnapshotsData):
year_low: Optional[float] = Field(
description="The 52-week low.", alias="yearLow", default=None
)
market_cap: float = Field(
market_cap: Optional[float] = Field(
description="Market cap of the stock.", alias="marketCap", default=None
)
shares_outstanding: float = Field(
shares_outstanding: Optional[float] = Field(
description="Number of shares outstanding.",
alias="sharesOutstanding",
default=None,
)
eps: Optional[float] = Field(description="Earnings per share.", default=None)
pe: Optional[float] = Field(description="Price to earnings ratio.", default=None)
exchange: str = Field(description="The exchange of the stock.", default=None)
exchange: Optional[str] = Field(
description="The exchange of the stock.", default=None
)
timestamp: Optional[Union[int, float]] = Field(
description="The timestamp of the data.", default=None
)
Expand All @@ -73,6 +72,9 @@ class FMPMarketSnapshotsData(MarketSnapshotsData):
alias="earningsAnnouncement",
default=None,
)
name: Optional[str] = Field(
description="The name associated with the stock symbol.", default=None
)


class FMPMarketSnapshotsFetcher(
Expand Down
Loading