Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Bump anyio & sync pre-commit, openbb-devtools and GitHub workflows #6443

Merged
merged 9 commits into from
May 21, 2024

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented May 20, 2024

  1. Why?

    • Last release anyio version had to be pinned to v3->v4 to avoid import error
    • pre-commit hooks were out of sync vs openbb-devtools which defines GitHub workflow dependency versions
    • ruff version use in openbb-core was too restrictive and outdated
    • mypy errors were different in GitHub workflow and locally
  2. What?

    • Bump anyio ^3.7.0 -> ^4.3.0
    • Bump ruff ^0.1.6 -> >=0.1.6,<=0.4.4 (devtools uses ^0.4.4)
    • Bump black 24.1.0 -> 24.4.2 (devtools)
    • sync pre-commit hooks with openbb-devtools
    • Small ruff, mypy, pydocstyle fixes
    • Move dev dependency group from core to devtools pyptoject.toml
  3. Impact:

  4. Testing Done:

    • NA

@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels May 20, 2024
@montezdesousa montezdesousa changed the title Bugfix/update anyio ruff [Bugfix] Update anyio & sync pre-commit, openbb-devtools and GitHub workflows May 20, 2024
@montezdesousa montezdesousa requested a review from piiq May 20, 2024 18:13
Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump black to latest

openbb_platform/extensions/devtools/pyproject.toml Outdated Show resolved Hide resolved
@montezdesousa montezdesousa marked this pull request as ready for review May 21, 2024 09:47
@montezdesousa montezdesousa requested a review from piiq May 21, 2024 09:47
@montezdesousa montezdesousa changed the title [Bugfix] Update anyio & sync pre-commit, openbb-devtools and GitHub workflows [Bugfix] Bump anyio & sync pre-commit, openbb-devtools and GitHub workflows May 21, 2024
@montezdesousa montezdesousa changed the title [Bugfix] Bump anyio & sync pre-commit, openbb-devtools and GitHub workflows [BugFix] Bump anyio & sync pre-commit, openbb-devtools and GitHub workflows May 21, 2024
Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try. I would also remove the devtools section from cli, but that's for a different PR

@montezdesousa montezdesousa added this pull request to the merge queue May 21, 2024
Merged via the queue into develop with commit 1994b34 May 21, 2024
30 checks passed
@IgorWounds IgorWounds deleted the bugfix/update-anyio-ruff branch May 21, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug P1 platform OpenBB Platform security v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Installing openbb-core also installs ruff, prevents upgrade to ">=0.2.0
3 participants