Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Have openbb.stocks.search return a pd.DataFrame instead of None #3923

Closed
TahaSha opened this issue Jan 10, 2023 · 0 comments
Closed

[IMPROVE] Have openbb.stocks.search return a pd.DataFrame instead of None #3923

TahaSha opened this issue Jan 10, 2023 · 0 comments

Comments

@TahaSha
Copy link

TahaSha commented Jan 10, 2023

What's the feature that should be improved?
For the SDK, have openbb.stocks.search return the pd.DataFrame instead of None.

Describe how you would like the feature improved
Currently, you can only pass a file type to export_data such as "csv" to have your dataframe exported to a directory. It would also be convenient to return it as well for any further filtering or processing needed to be done.

OpenBB Version == '2.1.0'
Python Version == '3.9.6'
joey-walker added a commit to joey-walker/OpenBBTerminal that referenced this issue Feb 9, 2023
@joey-walker
Return a dataframe from stocks search, allow override to not export t…
373f387 
…o file system (OpenBB-finance#3923)
jmaslek added a commit that referenced this issue Feb 10, 2023
@jmaslek
Merge pull request #4193 from joey-walker/feature/search-return-df
7639d46 
Return a dataframe from stocks search, removed export to file system (#3923)
@jmaslek jmaslek closed this as completed Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmaslek @TahaSha