Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate live feeds from Pyth #2178

Merged
merged 12 commits into from Sep 21, 2022
Merged

Integrate live feeds from Pyth #2178

merged 12 commits into from Sep 21, 2022

Conversation

jose-donato
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@jose-donato jose-donato added the feat L Large T-Shirt size Feature label Jul 26, 2022
@jose-donato
Copy link
Contributor Author

jose-donato commented Aug 23, 2022

@DidierRLopes do we want to move this to close or keep it as draft until we figure out how we want to handle live feeds on the terminal?

@DidierRLopes
Copy link
Collaborator

@DidierRLopes do we want to move this to close or keep it as draft until we figure out how we want to handle live feeds on the terminal?

Let me have a think about this during this week/weekend, and I'll let you know. I can also play with it a bit :)

* some improvements to this pyth command

* minor improv
@DidierRLopes DidierRLopes added feat S Small T-Shirt size Feature and removed feat L Large T-Shirt size Feature labels Aug 27, 2022
@DidierRLopes
Copy link
Collaborator

@jose-donato can you solve the requirements and then shall we merge and get feedback from the community regarding this first "real time" feature?

@jose-donato jose-donato marked this pull request as ready for review September 13, 2022 10:42
@jose-donato jose-donato merged commit 1661ddd into main Sep 21, 2022
@jose-donato jose-donato deleted the pyth branch September 21, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants