Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bullrun.com.br as source for research #2386

Merged
merged 4 commits into from Aug 26, 2022
Merged

add bullrun.com.br as source for research #2386

merged 4 commits into from Aug 26, 2022

Conversation

glaucocustodio
Copy link
Contributor

@glaucocustodio glaucocustodio commented Aug 22, 2022

Description

  • Add bullrun.com.br as source for research (very good to research brazilian stocks), see example: https://bullrun.com.br/acoes/petr4
  • Sort alphabetically available sources

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
    stocks -> load petr4.sa -> res -> bullrun
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the feat XS Extra small feature label Aug 22, 2022
@glaucocustodio
Copy link
Contributor Author

Can you ask someone to review please @colin99d?

Copy link
Collaborator

@DidierRLopes DidierRLopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @glaucocustodio !!

You know what we can add here though?

Since we just follow an hyperlink and append the ticket at the end, it would be nice for the user to customize the ticker. E.g. on Yfinance I need to load PBR.BA for Petrobras, whereas for bullrun it is expected petr3.

We could have a command in that menu called "ticker" that allowed users to select ticker name. What do you think?

@glaucocustodio
Copy link
Contributor Author

Nice one @glaucocustodio !!

You know what we can add here though?

Since we just follow an hyperlink and append the ticket at the end, it would be nice for the user to customize the ticker. E.g. on Yfinance I need to load PBR.BA for Petrobras, whereas for bullrun it is expected petr3.

We could have a command in that menu called "ticker" that allowed users to select ticker name. What do you think?

For brazilian stocks you just need to add the suffix ".sa", so petr3 is petr3.sa on yahoo finance.

If I choose res/bullrun it already removes the ".sa", so it reaches bullrun.com.br/acoes/petr3 👍🏻

Ps: "PBR.BA" seems to represent Petrobras trading at Argentina's stock exchange

Copy link
Collaborator

@DidierRLopes DidierRLopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good then! We can add the chance to change the ticker in the future! 🎉

@DidierRLopes DidierRLopes merged commit c341f46 into OpenBB-finance:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants