Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating poetry to v1.3.2 and dependencies #4076

Merged
merged 57 commits into from
Feb 9, 2023
Merged

Conversation

aia
Copy link
Contributor

@aia aia commented Jan 30, 2023

Description

Updating poetry to the latest version and updating dependencies

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Jan 30, 2023
@jmaslek
Copy link
Collaborator

jmaslek commented Feb 2, 2023

For some reason this is not playing nice with our installer builds:

https://github.com/OpenBB-finance/OpenBBTerminal/actions/runs/4078472572/jobs/7028721212

Updating 'build_env' env from conda env update...
  /Users/runner/miniconda3/condabin/conda env update --name build_env --file build/conda/conda-3-9-env-full.yaml
  Collecting package metadata (repodata.json): ...working... done
  Solving environment: ...working... done
  Installing pip dependencies: ...working... ::warning::Pip subprocess error:%0AERROR: Invalid requirement: 'poetry=1.3.2' (from line 1 of /Users/openbb/actions-runner/_work/OpenBBTerminal/OpenBBTerminal/build/conda/condaenv.khv74uvp.requirements.txt)%0AHint: = is not a valid operator. Did you mean == ?%0A%0A
  Pip subprocess error:
  ERROR: Invalid requirement: 'poetry=1.3.2' (from line 1 of /Users/openbb/actions-runner/_work/OpenBBTerminal/OpenBBTerminal/build/conda/condaenv.khv74uvp.requirements.txt)
  Hint: = is not a valid operator. Did you mean == ?
  
  Ran pip subprocess with arguments:
  ['/Users/runner/miniconda3/envs/build_env/bin/python', '-m', 'pip', 'install', '-U', '-r', '/Users/openbb/actions-runner/_work/OpenBBTerminal/OpenBBTerminal/build/conda/condaenv.khv74uvp.requirements.txt', '--exists-action=b']
  Pip subprocess output:
  
  failed
  Warning: 
  CondaEnvException: Pip failed

@aia
Copy link
Contributor Author

aia commented Feb 2, 2023

For some reason this is not playing nice with our installer builds:

My bad, was a syntax error.
Fixed.

@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat XS Extra small feature labels Feb 3, 2023
@reviewpad reviewpad bot added feat M Medium T-Shirt size feature and removed feat S Small T-Shirt size Feature labels Feb 6, 2023
@piiq piiq mentioned this pull request Feb 7, 2023
@reviewpad reviewpad bot added feat XS Extra small feature and removed feat M Medium T-Shirt size feature labels Feb 9, 2023
@piiq piiq merged commit 4f915e6 into develop Feb 9, 2023
@piiq piiq deleted the feature/poetry-update branch February 9, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants