Showing portfolio portfolios after optimizing in po now works, cash comment removed from portfolio docs and Parameter file info added
#4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerBouma
changed the title
JerBouma
changed the title
This was
linked to
issues
Feb 6, 2023
JerBouma
changed the title
portfolio portfolios after optimizing in po now works, cash comment removed from portfolio docs and Parameter file info added
reviewpad
bot
added
feat M
reviewpad
bot
added
feat XS
jmaslek
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes:
show, fixing [Bug] Entering the PO menu from the Portfolio menu does not recognize the already defined categories. #4137portfolio/pomenu given both the complexity and investment beliefs attached to this configuration, would be at random.Careful consideration and discussion has been done regarding not having cash (deposits and withdrawals) within the transactions data. This adds in complexity whereas the added benefit is not necessarily massive. E.g. a fund aims to have a cash position of zero anyways, moving funds between assets. Also note that the menu currently is a proof of concept and therefore has limitations regarding profits and levered positions. There is only so much we can work on ;)
Within the order book, cash is always taken out of the equation. The assumption is that you are able to fund any order you make and have exactly that portion of cash available leaving your net cash position always at 0. Therefore, any order you make always occurs the following way:
You note the profit you received here. E.g. let’s say you sell for $2500 and you invested $2000. This means that your total invested amount reduces by $2000 and your total value by $2500. E.g. $5000 total invested and $7500 total value changes to $3000 total invested and $5000 total value. You’d have a +$500 profit that is taken out of the equation and stored separately. Again, assumption is that the $2000 goes back to your bank account. Whenever you make investments, you deduct this amount of the investment you do (if reachable). E.g. I invest $2000, then I add in $1500 to total invested and $2000 to total value ($1500 + 500 of the “profit”) and I set my reserves to 0.
Complexity arrises when you invest 500, 500 and 500 and then decide to sell 750. Do you use FIFO, LIFO, WACC. Should it feature a time component? Methods we will have in the future when we expand the functionality.
See how portfolio --> po now works.
How has this been tested?
Checklist:
Others