-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add login command #4509
Add login command #4509
Conversation
I must have previously used the 'remember me' option, but login when already logged in throws an error:
(if it matters, I overwrote the is_auth_enabled() to always be true) |
Seems even logging out then in:
|
yesss, forgot a |
@@ -19,7 +19,7 @@ def main(): | |||
else: | |||
from openbb_terminal.core.session import session_controller | |||
|
|||
if is_auth_enabled(): | |||
if is_auth_enabled() and ("--login" in sys.argv[1:] or is_installer()): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will installer users need to set the flag in the .env
to test the login functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just make this function return True lol. But until we launch, yeah
This PR also fixes #4302. Well done @montezdesousa ! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4509 +/- ##
==========================================
Coverage ? 55.37%
==========================================
Files ? 585
Lines ? 53215
Branches ? 0
==========================================
Hits ? 29470
Misses ? 23745
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
* fix show version * update login prompt and account * update set preference * fix account controller * block login/logout if not called from account * change conditions to start terminal * fix required args account model * add not to login command * pylint * accounte controller messages * set default user when logout * logout then show menu * remove unused functions * fix logging bug * ruff * fix account unittests * fix session unittests --------- Co-authored-by: James Maslek <jmaslek11@gmail.com>
Description
OPENBB_ENABLE_AUTHENTICATION='True'
to testHow has this been tested?
Checklist:
feature/feature-name
orhotfix/hotfix-name
.Others