Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Finviz Error #4518

Merged
merged 4 commits into from
Mar 17, 2023
Merged

Fix Finviz Error #4518

merged 4 commits into from
Mar 17, 2023

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Mar 17, 2023

Description

Fixes #3513

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 17, 2023
@colin99d colin99d changed the title Hotfix/3513 Fix Finviz Error Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@1dffba8). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4518   +/-   ##
==========================================
  Coverage           ?   54.56%           
==========================================
  Files              ?      584           
  Lines              ?    52678           
  Branches           ?        0           
==========================================
  Hits               ?    28742           
  Misses             ?    23936           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek jmaslek added this pull request to the merge queue Mar 17, 2023
@jmaslek jmaslek merged commit 4e7f820 into develop Mar 17, 2023
@piiq piiq deleted the hotfix/3513 branch March 22, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
2 participants