Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First introduction of news_biztoc — A new partnership with BizToc.com #4864

Merged
merged 42 commits into from
May 10, 2023
Merged

First introduction of news_biztoc — A new partnership with BizToc.com #4864

merged 42 commits into from
May 10, 2023

Conversation

marban
Copy link
Contributor

@marban marban commented Apr 22, 2023

Description

Introduces the first set of features for news_biztoc, following a new partnership with BizToc.
Available at launch:

  • News / latest
  • News / per source
  • News / search
  • News / tag
  • Tags / list
  • Sources / list

TBD:

  • News / hot
  • News / page

See https://api.biztoc.com for details.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label Apr 22, 2023
@marban marban mentioned this pull request Apr 22, 2023
Closed
2 tasks
jmaslek and others added 6 commits April 25, 2023 21:31
@jmaslek
Merge pull request #4899 from OpenBB-finance/release/3.0.0
90da4e2 
Release/3.0.0
@tehcoderer
bump pywry
a00d6ef
@jmaslek
Merge pull request #4906 from tehcoderer/hotfix/pywry-merge-fix
7cba702 
hotfix / pywry bump
@montezdesousa @hjoaquim @jmaslek
fix rm command (#4890)
839638b 
Co-authored-by: Henrique Joaquim <h.joaquim@campus.fct.unl.pt>
@montezdesousa @hjoaquim @jmaslek
Fix crypto/defi/anchor (#4892)
e7b8b38 
* handle defi anchor exceptions

* reason

* mypy

---------

Co-authored-by: Henrique Joaquim <h.joaquim@campus.fct.unl.pt>
@jmaslek
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
2558f94 
…minal into develop
minhhoang1023
minhhoang1023 reviewed Apr 26, 2023
View reviewed changes
openbb_terminal/terminal_controller.py Outdated Show resolved Hide resolved
openbb_terminal/terminal_controller.py
nargs="+",
help="search for a term on the news",
)
parse.add_argument(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add these available options to the auto-completion? So it will look something like this:
and users don't need to run a separate command to see all the available tags.

Screenshot 2023-04-26 at 15 19 22

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do the tags for auto complete, but the sources for auto complete won't work because then it overwrites the other source.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmaslek we should change the source to something else. source here should refer to provider, not news source

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so source does make sense here, ie find bbg or yahoo etc. we also have the sources flag, which may be kinda similar, but the autocomplete differentiates between them.

tehcoderer and others added 17 commits April 26, 2023 10:28
@tehcoderer
fix windows pyinstaller subprocess fail if space in path
61dffa0
@tehcoderer
remove API_IEX_TOKEN
30d5e58
@tehcoderer
remove API_SENTIMENTINVESTOR_TOKEN
915dd1f
@jmaslek
Merge pull request #4910 from tehcoderer/hotfix/windows-installer
94a31f0 
hotfix/ fix windows pyinstaller subprocess fail if space in path
@jmaslek
Merge branch 'main' of https://github.com/OpenBB-finance/OpenBBTerminal…
a949fd2 
… into develop
@jmaslek
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
c570d0e 
…minal into develop
@jmaslek
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
dc55a43 
…minal into develop
@jmaslek
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
b0a9f7a 
…minal into develop
@jmaslek
Merge branch 'develop' into feature/biztoc
d383d66
@jmaslek
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
1c65986 
…minal into develop
@jmaslek
Add autocompletion and merge into one news function + add to sources …
c682858 
…dictionary
@jmaslek
Autocomplete for the tag
2454037
@jmaslek
fix test
8ab61ff
@jmaslek
Make a new sdk help[er for openbb.news
23b3285
@jmaslek
pylint
c930928
@jmaslek
lint
06f38c4
@jmaslek
lint2
c3c1438
@codecov
Copy link

codecov bot commented Apr 28, 2023 •
edited

Codecov Report

Patch coverage: 37.24% and project coverage change: -0.29 ⚠️

Comparison is base (df9a154) 58.29% compared to head (63b1594) 58.00%.

❗ Current head 63b1594 differs from pull request most recent head f5a1f90. Consider uploading reports for the commit f5a1f90 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4864      +/-   ##
===========================================
- Coverage    58.29%   58.00%   -0.29%     
===========================================
  Files          588      591       +3     
  Lines        53666    53853     +187     
===========================================
- Hits         31283    31236      -47     
- Misses       22383    22617     +234
Impacted Files Coverage Δ
.../core/plots/plotly_ta/plugins/volatility_plugin.py 31.37% <0.00%> (-1.29%) ⬇️
...inal/core/sdk/controllers/crypto_sdk_controller.py 0.00% <ø> (ø)
...inal/core/sdk/controllers/stocks_sdk_controller.py 0.00% <ø> (ø)
...penbb_terminal/core/sdk/models/crypto_sdk_model.py 0.00% <0.00%> (ø)
openbb_terminal/core/sdk/models/keys_sdk_model.py 0.00% <0.00%> (ø)
...penbb_terminal/core/sdk/models/stocks_sdk_model.py 0.00% <0.00%> (ø)
openbb_terminal/core/sdk/sdk_helpers.py 36.92% <ø> (ø)
openbb_terminal/core/sdk/sdk_init.py 92.75% <ø> (ø)
openbb_terminal/core/sdk/trailmap.py 92.68% <ø> (ø)
openbb_terminal/dashboards/stream/Forecasting.py 0.00% <0.00%> (ø)
... and 31 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

jmaslek and others added 8 commits May 1, 2023 16:59
@jmaslek
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
b3fe93c 
…minal into develop
@marban
Merge branch 'OpenBB-finance:develop' into feature/biztoc
63b1594
@jmaslek
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
9b6a61f 
…minal into develop
@jmaslek
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
a3066c5 
…minal into develop
@jmaslek
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
9d6615a 
…minal into develop
@jmaslek
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
424a9a9 
…minal into develop
@jmaslek
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
c01af20 
…minal into develop
@jmaslek
Merge branch 'develop' of https://github.com/OpenBB-finance/OpenBBTer…
7d317ce 
…minal into develop
minhhoang1023
minhhoang1023 reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@minhhoang1023 minhhoang1023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@jmaslek jmaslek added this pull request to the merge queue May 10, 2023
Merged via the queue into OpenBB-finance:develop with commit 29a297c May 10, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minhhoang1023 minhhoang1023 minhhoang1023 approved these changes

@jmaslek jmaslek Awaiting requested review from jmaslek

Assignees
No one assigned
Labels
feat M Medium T-Shirt size feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marban @jmaslek @minhhoang1023 @tehcoderer @montezdesousa