Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stocks/disc/cnews command #4920

Merged
merged 6 commits into from
Apr 27, 2023
Merged

Remove stocks/disc/cnews command #4920

merged 6 commits into from
Apr 27, 2023

Conversation

piiq
Copy link
Contributor

@piiq piiq commented Apr 27, 2023

The bug in the cnews (customized news) command was identified in the integration test logs.
The cnews command that scrapes a seekingalpha page now bumps into a capcha window and does not work any more.
image

This PR removes the command from the terminal, SDK, translations, default sources json, tests and intros section of the documentation.

I've updated the tests for the controller and the seeking aplha model and view

Note: there were a few duplicate fields in the default_sources.json that I've cleaned up

Question to @jose-donato: Will need to update the default sources section on the hub manually?

@piiq piiq added the bug Fix bug label Apr 27, 2023
@piiq piiq requested a review from jmaslek April 27, 2023 14:22
@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label Apr 27, 2023
@reviewpad
Copy link

reviewpad bot commented Apr 27, 2023

Reviewpad Report

⚠️ Warnings

  • The pyproject.toml file has been changed. Please make sure that the files requirements.txt and requirements-full.txt do not need to be updated

Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-04-27 at 10 51 26 AM
Screenshot 2023-04-27 at 10 53 22 AM

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: -0.02 ⚠️

Comparison is base (1444141) 58.28% compared to head (34f2597) 58.27%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4920      +/-   ##
===========================================
- Coverage    58.28%   58.27%   -0.02%     
===========================================
  Files          588      588              
  Lines        53667    53633      -34     
===========================================
- Hits         31280    31253      -27     
+ Misses       22387    22380       -7     
Impacted Files Coverage Δ
...inal/core/sdk/controllers/stocks_sdk_controller.py 0.00% <ø> (ø)
...penbb_terminal/core/sdk/models/stocks_sdk_model.py 0.00% <ø> (ø)
...minal/cryptocurrency/due_diligence/messari_view.py 24.12% <ø> (+0.12%) ⬆️
...penbb_terminal/stocks/discovery/disc_controller.py 90.66% <ø> (-0.06%) ⬇️
...b_terminal/stocks/discovery/seeking_alpha_model.py 77.02% <ø> (-2.98%) ⬇️
openbb_terminal/terminal_controller.py 17.45% <0.00%> (+0.08%) ⬆️
...terminal/cryptocurrency/defi/cryptosaurio_model.py 87.09% <20.00%> (-5.77%) ⬇️
openbb_terminal/helper_funcs.py 49.69% <33.33%> (+<0.01%) ⬆️
..._terminal/cryptocurrency/defi/cryptosaurio_view.py 91.66% <90.00%> (-3.58%) ⬇️
...bb_terminal/stocks/discovery/seeking_alpha_view.py 71.79% <100.00%> (-3.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek jmaslek added this pull request to the merge queue Apr 27, 2023
Merged via the queue into develop with commit 1820420 Apr 27, 2023
13 of 15 checks passed
@jmaslek jmaslek deleted the hotfix/remove-cnews branch May 1, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat M Medium T-Shirt size feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants