Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / Logging #4923

Merged
merged 19 commits into from
Apr 28, 2023
Merged

Feature / Logging #4923

merged 19 commits into from
Apr 28, 2023

Conversation

tehcoderer
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 26.31% and project coverage change: -0.08 ⚠️

Comparison is base (df9a154) 58.29% compared to head (bf615b8) 58.22%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4923      +/-   ##
===========================================
- Coverage    58.29%   58.22%   -0.08%     
===========================================
  Files          588      588              
  Lines        53666    53710      +44     
===========================================
- Hits         31283    31270      -13     
- Misses       22383    22440      +57     
Impacted Files Coverage Δ
...inal/core/sdk/controllers/stocks_sdk_controller.py 0.00% <ø> (ø)
...penbb_terminal/core/sdk/models/stocks_sdk_model.py 0.00% <ø> (ø)
openbb_terminal/dashboards/stream/Forecasting.py 0.00% <0.00%> (ø)
...bb_terminal/dashboards/stream/streamlit_helpers.py 0.00% <0.00%> (ø)
openbb_terminal/forecast/autoselect_model.py 10.44% <0.00%> (-0.33%) ⬇️
openbb_terminal/forecast/helpers.py 1.56% <ø> (+<0.01%) ⬆️
openbb_terminal/futures/yfinance_view.py 69.86% <ø> (ø)
...penbb_terminal/stocks/discovery/disc_controller.py 90.66% <ø> (-0.06%) ⬇️
...b_terminal/stocks/discovery/seeking_alpha_model.py 77.02% <ø> (-2.98%) ⬇️
openbb_terminal/loggers.py 59.28% <24.19%> (-21.10%) ⬇️
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek jmaslek added this pull request to the merge queue Apr 28, 2023
Merged via the queue into develop with commit 9026a41 Apr 28, 2023
13 of 15 checks passed
@jmaslek jmaslek deleted the feature/posthog-logging branch May 1, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants