Hotfix/routine default file overwrite

[Ltwo3five]

Description

- Summary of the change / bug fix.

Personal routines created on https://my.openbb.co/app/terminal/routines with the same name as default routines 
overwrite the default routine in the hubs folder. This was caused by the dictionary routines_dict in 
routines_handler.download_routines having the same key so the default script gets overwritten in the hubs folder. My 
solution  was to create two dictionaries one for personal routines and the other one for default routines and store them in 
a list. 
[{"A" : ["script","personal]}, {"B" : ["script","default"]}]
Another change I  made was to store personal routines and default routines in two separate folders in the hub folder. To 
do this, I put the routine script in a list as the first element, and the string "default" or "personal as the second element to 
denote their respective types. ["script", "personal/default"]
I made changes in call_download in the accounts controller to account for the changes in save routines 
and in download_and_save routines in session_model.py  to account for the changes in download_routines and      
save_routines in routines_handler.py. Lastly I made changes to read_routine in routines_handler.py to account for the 
change in directory structure so the files in their respective folders can still be found.

- Link to the issue

#4826

- Relevant motivation and context.

I think it would make more sense for there to be two folders in the hubs folder for easy navigation and to allow
users to locate files with the same names more easily.
personal routines created on the website with the same name as default routines are causing the latter to be overwritten
when both routines are downloaded from the server.

- dependencies

import walk from os

How has this been tested?

-Please describe the tests that you ran to verify your changes.

I redid the unit test for test_read_routines and test_read_routines_exception in test_routines_handler, and I updated the unit
tests for call_download in test_account_controller to account for the change in parameters for the save_routine mock.
I performed end to end test by testing the upload, download, list, and delete commands for routines. I also went to
https://my.openbb.co/app/terminal/routines and created a new personal routine with the same name as the default routine
to verify the changes have fixed the issue.
I made unit tests for download_routines in test_routines_handler. The first test tests if the function returns the correct object
the rest of the tests test for when downloading personal routines raises an exception, when downloading default routines
raises an exception and when downloading both personal and default routines raises an exception

-Provide instructions so we can reproduce.

Run relevant pytests and call commands listed above.
Go to the routines folder when logged into account
Go to https://my.openbb.co/app/terminal/routines and create a new personal routine with the same name as default

-Please also list any relevant details for your test configuration.

I redid test_read_routine and test_read_routine_exception to create new mocks for os.walk and .os.path.relpath and to
test the logic and parameter changes in the function. I also removed mocks that are not relevant.

• Make sure affected commands still run in terminal
• Ensure the SDK still works
• Check any related reports

Checklist:

• I have adhered to the GitFlow naming convention and my branch name is in the format of feature/feature-name or hotfix/hotfix-name.
• Update our documentation following these guidelines. Update any user guides that are affected by the changes.
• Update our tests following these guidelines.
• Make sure you are following our CONTRIBUTING guidelines.
• If a feature was added make sure to add it to the corresponding integration test script.

Others

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.

[montezdesousa]

Hi, thanks for the PR.

IIUC, if I create a routine with name already in use by default routines like The Influence of the Central Bank.openbb and run exe --file The Influence of the Central Bank.openbb it executes the default routine, right?

Did you consider how to run the personal routine with the same name? The simple way to achieve this would be to specify the full path
exe --file /Users/username/OpenBBUserData/routines/hub/personal/The Influence of the Central Bank.openbb, but does not work on my side. If this not easy to do in this PR we open a new issue (e.g. "Allow running routines from path") and take it elsewhere.

[Ltwo3five]

Hi, thanks for the PR.

IIUC, if I create a routine with name already in use by default routines like The Influence of the Central Bank.openbb and run exe --file The Influence of the Central Bank.openbb it executes the default routine, right?

Did you consider how to run the personal routine with the same name? The simple way to achieve this would be to specify the full path exe --file /Users/username/OpenBBUserData/routines/hub/personal/The Influence of the Central Bank.openbb, but does not work on my side. If this not easy to do in this PR we open a new issue (e.g. "Allow running routines from path") and take it elsewhere.

Hello , I missed that and did not take that the exe command after the user logs in into consideration. I know where the issue is and will push the changes when I am done.

[Ltwo3five]

Hi Monte, I have pushed the changes.
A user can now put in --file default/filename.openbb, --file personal/filename.openbb or --file user/username/openBBUserData/routines/~. Full path was working before, the issue was that C: has to be specified before /users. I have made a regex to account for when a user puts in C:/ at the beginning of the path and when they don't.

[montezdesousa]

Hi Monte, I have pushed the changes. A user can now put in --file default/filename.openbb, --file personal/filename.openbb or --file user/username/openBBUserData/routines/~. Full path was working before, the issue was that C: has to be specified before /users. I have made a regex to account for when a user puts in C:/ at the beginning of the path and when they don't.

Hi, apparently exe --file /Users/username/OpenBBUserData/routines/hub/personal/The Influence of the Central Bank.openbb seems to work now if I remove the regex, I will write the suggestion in the review.

Otherwise, I get this (since I'm on mac). Windows user might not use C drive as well. So it's better to force user to specify that if needed.

Error: [Errno 2] No such file or directory: 'C:/Users/username/OpenBBUserData/routines/hub/personal/The Influence of the Central Bank.openbb'

[montezdesousa]

Suggested change

	full_path = Path('C:/' + re.sub(r'^(C:\/?|c:\/?)', '', file_path).strip())
	full_path = file_path

[Ltwo3five]

I am not sure why it is not working with the regex for you as it is the opposite for me and
exe --file /Users/username/OpenBBUserData/routines/hub/personal/The Influence of the Central Bank.openbb only works for me with the regex otherwise i need to include the C drive at the start for it to work without regex.

[Ltwo3five]

But I guess it is better to remove the regex as the full path with the C:/ at the start still works with or without it. The purpose of the regex was for users to be able to choose to include the C;/ or not include it and the path will still work but at the end of the day the issue seems trivial and it was simply for convenience

[montezdesousa]

Here we should give priority to user routines if there's a naming conflict.

                name = " ".join(ns_parser.name)
                if name in self.REMOTE_CHOICES:
                    # User routine
                    response = Hub.download_routine(
                        auth_header=get_current_user().profile.get_auth_header(),
                        name=name,
                    )
                    data = [
                        (
                            response.json()
                            if response and response.status_code == 200
                            else None
                        ),
                        "personal",
                    ]
                else:
                    # Default routine
                    data = [
                        next(
                            (r for r in self.DEFAULT_ROUTINES if r["name"] == name),
                            None,
                        ),
                        "default",
                    ]

[montezdesousa]

I've made a couple suggestions and fixed linting, other than that looks good to me!

[Ltwo3five]

I've made a couple suggestions and fixed linting, other than that looks good to me!

Thank you!