Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commas from i18n #4952

Merged
merged 2 commits into from
May 2, 2023
Merged

Remove commas from i18n #4952

merged 2 commits into from
May 2, 2023

Conversation

IgorWounds
Copy link
Contributor

Removed the appearance of submenu commas inside the i18n. This closes #4950 issue.

@IgorWounds IgorWounds added the bug Fix bug label May 2, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label May 2, 2023
@reviewpad reviewpad bot added feat L Large T-Shirt size Feature and removed feat XS Extra small feature labels May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 48.96% and project coverage change: -0.20 ⚠️

Comparison is base (df9a154) 58.29% compared to head (af3a487) 58.09%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4952      +/-   ##
===========================================
- Coverage    58.29%   58.09%   -0.20%     
===========================================
  Files          588      588              
  Lines        53666    53696      +30     
===========================================
- Hits         31283    31196      -87     
- Misses       22383    22500     +117     
Impacted Files Coverage Δ
.../core/plots/plotly_ta/plugins/volatility_plugin.py 31.37% <0.00%> (-1.29%) ⬇️
...inal/core/sdk/controllers/crypto_sdk_controller.py 0.00% <ø> (ø)
...inal/core/sdk/controllers/stocks_sdk_controller.py 0.00% <ø> (ø)
...penbb_terminal/core/sdk/models/crypto_sdk_model.py 0.00% <0.00%> (ø)
...bb_terminal/core/sdk/models/portfolio_sdk_model.py 0.00% <0.00%> (ø)
...penbb_terminal/core/sdk/models/stocks_sdk_model.py 0.00% <0.00%> (ø)
openbb_terminal/core/sdk/sdk_helpers.py 36.92% <ø> (ø)
openbb_terminal/core/sdk/sdk_init.py 92.75% <ø> (ø)
openbb_terminal/core/sdk/trailmap.py 92.68% <ø> (ø)
openbb_terminal/dashboards/stream/Forecasting.py 0.00% <0.00%> (ø)
... and 28 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek jmaslek added this pull request to the merge queue May 2, 2023
Merged via the queue into develop with commit fd9d6fd May 2, 2023
15 of 17 checks passed
@IgorWounds IgorWounds deleted the hotfix/remove-submenu-commas branch May 2, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat L Large T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] i18n.yaml file has strange commas that appear in menus.
2 participants