Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/stocks quote help description: replaces help dialogue description for --ticker. #4953

Merged
merged 2 commits into from
May 3, 2023

Conversation

deeleeramone
Copy link
Contributor

Cosmetic fix that replaces the text in the help dialogue under the --ticker argument.

Before:

Screenshot 2023-05-02 at 5 40 33 PM

After:

Screenshot 2023-05-02 at 6 04 29 PM

@reviewpad reviewpad bot added the feat XS Extra small feature label May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 49.23% and project coverage change: -0.20 ⚠️

Comparison is base (df9a154) 58.29% compared to head (7e6e032) 58.09%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4953      +/-   ##
===========================================
- Coverage    58.29%   58.09%   -0.20%     
===========================================
  Files          588      588              
  Lines        53666    53696      +30     
===========================================
- Hits         31283    31195      -88     
- Misses       22383    22501     +118     
Impacted Files Coverage Δ
.../core/plots/plotly_ta/plugins/volatility_plugin.py 31.37% <0.00%> (-1.29%) ⬇️
...inal/core/sdk/controllers/crypto_sdk_controller.py 0.00% <ø> (ø)
...inal/core/sdk/controllers/stocks_sdk_controller.py 0.00% <ø> (ø)
...penbb_terminal/core/sdk/models/crypto_sdk_model.py 0.00% <0.00%> (ø)
...bb_terminal/core/sdk/models/portfolio_sdk_model.py 0.00% <0.00%> (ø)
...penbb_terminal/core/sdk/models/stocks_sdk_model.py 0.00% <0.00%> (ø)
openbb_terminal/core/sdk/sdk_helpers.py 36.92% <ø> (ø)
openbb_terminal/core/sdk/sdk_init.py 92.75% <ø> (ø)
openbb_terminal/core/sdk/trailmap.py 92.68% <ø> (ø)
openbb_terminal/dashboards/stream/Forecasting.py 0.00% <0.00%> (ø)
... and 28 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek jmaslek added this pull request to the merge queue May 3, 2023
Merged via the queue into develop with commit 02339c4 May 3, 2023
12 of 16 checks passed
@piiq piiq deleted the hotfix/stocks-quote-help-description branch June 4, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants