Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing wrong transposition #4959

Merged
merged 2 commits into from
May 3, 2023
Merged

Removing wrong transposition #4959

merged 2 commits into from
May 3, 2023

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented May 3, 2023

Removing the transposed() so that years are displayed as columns instead of rows, for the following commands:

  • income
  • balance
  • cash
  • growth
  • metrics
  • ratios

@hjoaquim hjoaquim requested review from jmaslek and JerBouma May 3, 2023 11:45
@reviewpad reviewpad bot added the feat XS Extra small feature label May 3, 2023
@jmaslek
Copy link
Collaborator

jmaslek commented May 3, 2023

These transpose in the exports are intentional. Without them, you cannot overlay them onto the pywry charts.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 60.53% and project coverage change: -0.19 ⚠️

Comparison is base (df9a154) 58.29% compared to head (01ab715) 58.10%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4959      +/-   ##
===========================================
- Coverage    58.29%   58.10%   -0.19%     
===========================================
  Files          588      588              
  Lines        53666    53821     +155     
===========================================
- Hits         31283    31272      -11     
- Misses       22383    22549     +166     
Impacted Files Coverage Δ
.../core/plots/plotly_ta/plugins/volatility_plugin.py 31.37% <0.00%> (-1.29%) ⬇️
...inal/core/sdk/controllers/crypto_sdk_controller.py 0.00% <ø> (ø)
...inal/core/sdk/controllers/stocks_sdk_controller.py 0.00% <ø> (ø)
...penbb_terminal/core/sdk/models/crypto_sdk_model.py 0.00% <0.00%> (ø)
...penbb_terminal/core/sdk/models/stocks_sdk_model.py 0.00% <0.00%> (ø)
openbb_terminal/core/sdk/sdk_helpers.py 36.92% <ø> (ø)
openbb_terminal/core/sdk/sdk_init.py 92.75% <ø> (ø)
openbb_terminal/core/sdk/trailmap.py 92.68% <ø> (ø)
openbb_terminal/dashboards/stream/Forecasting.py 0.00% <0.00%> (ø)
...bb_terminal/dashboards/stream/streamlit_helpers.py 0.00% <0.00%> (ø)
... and 36 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hjoaquim
Copy link
Contributor Author

hjoaquim commented May 3, 2023

These transpose in the exports are intentional. Without them, you cannot overlay them onto the pywry charts.

I see!
@jmaslek @JerBouma should we fix this by having an argument --trasponse that controls this behavior?

@JerBouma
Copy link
Contributor

JerBouma commented May 3, 2023

Perhaps this is an isolated case but for Financial Statements, you should be able to export them as we had originally.

I don't want to need to add a --transpose flag just to get a Financial Statement how it is supposed to be presented.

@jmaslek
Copy link
Collaborator

jmaslek commented May 3, 2023

lets get rid and @tehcoderer will figure out how to have a transpose option in PyWru

@jmaslek jmaslek enabled auto-merge May 3, 2023 12:35
@jmaslek jmaslek added this pull request to the merge queue May 3, 2023
Merged via the queue into develop with commit 7c10fac May 3, 2023
14 of 15 checks passed
@piiq piiq deleted the hotfix/fix-transposed-tables branch June 4, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants