Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed column names for economy\performance and economy\valuation #4968

Merged
merged 3 commits into from
May 4, 2023

Conversation

the-praxs
Copy link
Contributor

Fixes #4966.

@reviewpad reviewpad bot added the feat XS Extra small feature label May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 61.20% and project coverage change: -0.19 ⚠️

Comparison is base (df9a154) 58.29% compared to head (6b4ba1b) 58.10%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4968      +/-   ##
===========================================
- Coverage    58.29%   58.10%   -0.19%     
===========================================
  Files          588      588              
  Lines        53666    53825     +159     
===========================================
- Hits         31283    31275       -8     
- Misses       22383    22550     +167     
Impacted Files Coverage Δ
.../core/plots/plotly_ta/plugins/volatility_plugin.py 31.37% <0.00%> (-1.29%) ⬇️
...inal/core/sdk/controllers/crypto_sdk_controller.py 0.00% <ø> (ø)
...inal/core/sdk/controllers/stocks_sdk_controller.py 0.00% <ø> (ø)
...penbb_terminal/core/sdk/models/crypto_sdk_model.py 0.00% <0.00%> (ø)
...penbb_terminal/core/sdk/models/stocks_sdk_model.py 0.00% <0.00%> (ø)
openbb_terminal/core/sdk/sdk_helpers.py 36.92% <ø> (ø)
openbb_terminal/core/sdk/sdk_init.py 92.75% <ø> (ø)
openbb_terminal/core/sdk/trailmap.py 92.68% <ø> (ø)
openbb_terminal/dashboards/stream/Forecasting.py 0.00% <0.00%> (ø)
...bb_terminal/dashboards/stream/streamlit_helpers.py 0.00% <0.00%> (ø)
... and 39 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek jmaslek added this pull request to the merge queue May 4, 2023
Merged via the queue into OpenBB-finance:develop with commit 5a3b006 May 4, 2023
12 of 13 checks passed
@the-praxs the-praxs deleted the hotfix/4966 branch May 8, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] /economy/performance & valuation Error: 'Name' - Error: 'list' object has no attribute 'empty'
2 participants