Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Restores Portfolio Optimization Parameters Template File #4976

Merged
merged 3 commits into from
May 9, 2023

Conversation

deeleeramone
Copy link
Contributor

This PR fixes #4961 and restores the params sub-menu so it works without users needing to sign-up for and login to Dropbox, just to get the template file which they must then place in their OpenBBUserData folder.

Before:

image

After:

Screenshot 2023-05-04 at 2 37 40 PM

Screenshot 2023-05-04 at 2 38 14 PM

@deeleeramone deeleeramone added bug Fix bug portfolio Portfolio menu labels May 4, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label May 4, 2023
@reviewpad
Copy link

reviewpad bot commented May 4, 2023

Reviewpad Report

Fatal

  • Images are not allowed in the repository, please remove images from the PR

@deeleeramone deeleeramone changed the title restores parameters template file [Bug] Restores Portfolio Optimization Parameters Template File May 4, 2023
@jmaslek jmaslek added this pull request to the merge queue May 9, 2023
Merged via the queue into develop with commit eaf27ab May 9, 2023
12 of 13 checks passed
@piiq piiq deleted the hotfix/portfolio-params-template branch June 4, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature portfolio Portfolio menu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Portfolio/po/file There are no templates or example files included in the Terminal for the parameters.
2 participants