Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create KEYBOARD_HOTKEY_MACROS.md #4986

Merged
merged 11 commits into from
May 10, 2023
Merged

Create KEYBOARD_HOTKEY_MACROS.md #4986

merged 11 commits into from
May 10, 2023

Conversation

DidierRLopes
Copy link
Collaborator

@DidierRLopes DidierRLopes commented May 7, 2023 •
edited

This is a document to explain how users can leverage VIA configurator to create custom hotkey routines to speed up investment research.

@hjoaquim @colin99d let me know if you think this is a good explanation, and/or where it can be improved!

@DidierRLopes DidierRLopes added the docs Code documentation label May 7, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label May 7, 2023
@DidierRLopes DidierRLopes marked this pull request as ready for review May 7, 2023 06:24
@the-praxs
Copy link
Contributor

Should this be implemented as a general feature, allowing anyone using VIA to create their own macros?

@DidierRLopes
Copy link
Collaborator Author

Should this be implemented as a general feature, allowing anyone using VIA to create their own macros?

Everyone should be able to use VIA to create their own macros, all needed is a mechanical keyboard that VIA supports. We can probably change the title away from "Keychron" as VIA supports other types of keyboards. Thoughts?

@DidierRLopes
Copy link
Collaborator Author

Should this be implemented as a general feature, allowing anyone using VIA to create their own macros?

I have refactored this to allow support to more configurators like VIA and not just highlight Keychron. @the-praxs @hjoaquim @colin99d

@DidierRLopes DidierRLopes changed the title Create KEYCHRON_MACROS.md Create KEYBOARD_HOTKEY_MACROS.md May 9, 2023
@the-praxs
Copy link
Contributor

Reviewed it, looks good to me.

@jmaslek jmaslek added this pull request to the merge queue May 10, 2023
Merged via the queue into develop with commit 33da518 May 10, 2023
12 checks passed
@piiq piiq deleted the feature/keychron_macros branch June 4, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoaquim hjoaquim hjoaquim approved these changes

Assignees

@hjoaquim hjoaquim

@colin99d colin99d

Labels
docs Code documentation feat XS Extra small feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DidierRLopes @the-praxs @hjoaquim @jmaslek @colin99d