Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pytrends dependency in config files and remove temp workaround #4989

Merged
merged 4 commits into from
May 9, 2023

Conversation

the-praxs
Copy link
Contributor

Description

  • Removed temp workaround for pytrends in google_model.py file.
  • Dependency change - pytrends>=4.9.2

How has this been tested?

  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label May 8, 2023
reviewpad[bot]
reviewpad bot previously requested changes May 8, 2023
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

@the-praxs the-praxs changed the title Updated pytrends dependency in config files Updated pytrends dependency in config files and remove temp workaround May 8, 2023
@jmaslek
Copy link
Collaborator

jmaslek commented May 9, 2023

Nice

Screenshot 2023-05-08 at 9 44 17 PM

Screenshot 2023-05-08 at 9 44 31 PM

@jmaslek jmaslek enabled auto-merge May 9, 2023 04:45
@jmaslek jmaslek added this pull request to the merge queue May 9, 2023
Merged via the queue into OpenBB-finance:develop with commit d86e5cc May 9, 2023
17 of 19 checks passed
@the-praxs the-praxs deleted the hotfix/pytrends-update branch May 10, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants