Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/ Candle Lines, Tables/Charts Save (MacOS) #5019

Merged
merged 15 commits into from
May 15, 2023

Conversation

tehcoderer
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat L Large T-Shirt size Feature label May 14, 2023
@deeleeramone
Copy link
Contributor

deeleeramone commented May 14, 2023

No volume exported from candle?

Date,Open,High,Low,Close
2020-05-11T00:00:00,53.393333435058594,54.93333435058594,52.33333206176758,53.51333332061768

The filename is kinda weird here. Might want to have a thing that replaces the three characters- with one _
.

Screenshot 2023-05-14 at 4 07 26 PM

@tehcoderer
Copy link
Contributor Author

No volume exported from candle?

Date,Open,High,Low,Close
2020-05-11T00:00:00,53.393333435058594,54.93333435058594,52.33333206176758,53.51333332061768

The filename is kinda weird here. Might want to have a thing that replaces the three characters- with one _ .

Screenshot 2023-05-14 at 4 07 26 PM

@deeleeramone fixeddd both

@reviewpad reviewpad bot added feat XL Extra Large feature and removed feat L Large T-Shirt size Feature labels May 15, 2023
@tehcoderer tehcoderer linked an issue May 15, 2023 that may be closed by this pull request
@jmaslek jmaslek added this pull request to the merge queue May 15, 2023
Merged via the queue into OpenBB-finance:develop with commit 3e03098 May 15, 2023
9 of 11 checks passed
@tehcoderer tehcoderer deleted the hotfix/candle-drawing branch May 15, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XL Extra Large feature
Projects
None yet
3 participants