Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update treasury command to get directly from fed #5215

Merged
merged 16 commits into from
Jul 14, 2023

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Jul 12, 2023

Fixes #5211 by changing from econdb to getting directly from the fed website. This will also resolve the economy report #5207

Note this is not a 1:1 redo of the function as I do not get any of the secondary or tips, etc. These can also be added down the road

Also throwing in a quick patch that fixes #5190
And another patch to fix #5172

@jmaslek jmaslek added the feat XS Extra small feature label Jul 12, 2023
@reviewpad reviewpad bot added feat M Medium T-Shirt size feature and removed feat XS Extra small feature labels Jul 12, 2023
@deeleeramone
Copy link
Contributor

deeleeramone commented Jul 13, 2023

Couple of minor things I'm noticing:

  • The choices for --maturity are not populating.
  • The query doesn't carry to the "stored datasets" section.
  • The help dialogue still implies a choice for nominal, inflation-adjusted, and secondary markets. Which ones are we looking at?
  • Can we also get the other ones, like the short term bill rates?
Screenshot 2023-07-12 at 5 44 09 PM Screenshot 2023-07-12 at 5 45 26 PM

This might be a difference source than you are tapping into though.

https://home.treasury.gov/resource-center/data-chart-center/interest-rates/TextView?type=daily_treasury_bill_rates&field_tdr_date_value=2023

@jmaslek
Copy link
Collaborator Author

jmaslek commented Jul 13, 2023

Couple of minor things I'm noticing:

  • The choices for --maturity are not populating.

Fixed

  • The query doesn't carry to the "stored datasets" section.

Most don't anymore and these should probably get deprecated moving forward.

  • The help dialogue still implies a choice for nominal, inflation-adjusted, and secondary markets. Which ones are we looking at?

Will get rid of these in help text. AFAIK its just the nominal. Can get the other ones from this site, but they only appear when downloading the monthly or weekly sets.

  • Can we also get the other ones, like the short term bill rates?

Screenshot 2023-07-12 at 5 44 09 PM Screenshot 2023-07-12 at 5 45 26 PM
This might be a difference source than you are tapping into though.

https://home.treasury.gov/resource-center/data-chart-center/interest-rates/TextView?type=daily_treasury_bill_rates&field_tdr_date_value=2023

Is a slightly different source. Could investigate down the road, but am looking to close the issue linked.

@jmaslek jmaslek force-pushed the feature/new-treasury-command branch from afebe69 to 13b9296 Compare July 13, 2023 17:00
@jmaslek jmaslek added this pull request to the merge queue Jul 14, 2023
Merged via the queue into develop with commit 830159f Jul 14, 2023
13 checks passed
@piiq piiq deleted the feature/new-treasury-command branch July 15, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat M Medium T-Shirt size feature
Projects
None yet
3 participants