Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] OpenBB Platform CLI #5302

Merged
merged 1,093 commits into from Apr 29, 2024
Merged

[Feature] OpenBB Platform CLI #5302

merged 1,093 commits into from Apr 29, 2024

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented Aug 9, 2023

  1. Why? (1-3 sentences or a bullet point list):

    • The OpenBB Terminal was unmaintainable.
  2. What? (1-3 sentences or a bullet point list):

    • Wrapping the OpenBB Platform in a CLI that resembles the former OpenBB Terminal.
  3. Impact (1-2 sentences or a bullet point list):

    • NA to the Platform
    • ∞ to the Terminal/CLI
  4. Testing Done:

    • Manually exploring the CLI.

@hjoaquim hjoaquim added the v4 PRs for v4 label Aug 9, 2023
@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label Aug 9, 2023
@hjoaquim hjoaquim marked this pull request as draft August 9, 2023 07:15
@deeleeramone
Copy link
Contributor

deeleeramone commented Apr 24, 2024

I'm not able to switch timezones because it splits on "/":

timezone -t America/New_York

(🦋) /settings/ $ timezone -t America/New_York


(🦋) /settings/ $ timezone -t America

Invalid timezone. Please enter a valid timezone.

@deeleeramone
Copy link
Contributor

I can't see any differences when applying "console_style" settings. What is supposed to happen between "light" and "dark"? The charts and tables each have their own preferences for light and dark, what is "console_style"?

@deeleeramone
Copy link
Contributor

@hjoaquim, whenever a table is opened, you must manually intervene to get back to the CL.

(🦋) / $ Received message from Python
New Window Created

@deeleeramone
Copy link
Contributor

The stock screener does not appear to work at all, no parameters are getting passed through to the request.

Platform:
Screenshot 2024-04-24 at 9 59 33 AM

CLI:
Screenshot 2024-04-24 at 10 00 59 AM

@deeleeramone
Copy link
Contributor

"system" opens a blank window. Some items should just print directly to the console instead of attempting to make an interactive table out of it.

Screenshot 2024-04-24 at 10 05 22 AM

@IgorWounds
Copy link
Contributor

timezone -t America/New_York

Fixed @deeleeramone

hjoaquim and others added 6 commits April 26, 2024 08:37
…ce/OpenBBTerminal into feature/argparse_translator
* Move terminal files into openbb_terminal

* move routines

* Create session to handle console, user, settings, etc.

* Reset...

* Bring back frontend-components

* Move frontend-components to openbb_terminal

* rename vars

* remove doc

* rename method

* rename method

* fix routines

* read settings from .env

* rename methods

* ^

* ^

* better

* bug

* ^

* move frontend-components back to root level

* revert changes

* type checking only

* docstring

* fix: settings autocomplete

* comment

* use openbb_core singleton

* rename src to fix openbb command

* fix poetry build

* readme

---------

Co-authored-by: hjoaquim <h.joaquim@campus.fct.unl.pt>
@hjoaquim
Copy link
Contributor Author

hjoaquim commented Apr 29, 2024

I can't see any differences when applying "console_style" settings. What is supposed to happen between "light" and "dark"? The charts and tables each have their own preferences for light and dark, what is "console_style"?

@deeleeramone
As the name says, it's the console "rich" style, example:

image

The difference it's subtle with the default style, but becomes more evident if you use a custom theme:

image

@hjoaquim
Copy link
Contributor Author

@hjoaquim, whenever a table is opened, you must manually intervene to get back to the CL.

(🦋) / $ Received message from Python
New Window Created

@deeleeramone
I believe this only happens when in debug mode.

@hjoaquim
Copy link
Contributor Author

@deeleeramone added the other which I didn't answer directly to the Jira ticket so they can be separately addressed.

@hjoaquim hjoaquim added this pull request to the merge queue Apr 29, 2024
Merged via the queue into develop with commit b43364b Apr 29, 2024
10 checks passed
@IgorWounds IgorWounds deleted the feature/argparse_translator branch April 30, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change enhancement Enhancement feat L Large T-Shirt size Feature P0 security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants