Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix routines creation from the Terminal to Hub #5312

Merged
merged 11 commits into from
Aug 14, 2023

Conversation

DidierRLopes
Copy link
Collaborator

@DidierRLopes DidierRLopes commented Aug 13, 2023

This should include:

  • Check that title only has characters, digits or white spaces
  • Title needs to be provided
  • Default description to generic sentence
  • Allow to run exe and record only from main menu. But allow stop from anywhere. - this guarantees the order of stuff and makes it easier for us.
  • Add auto-completer for tags in record command
  • Check that tags selected by user are valid
  • Replace white spaces by underscores to save file locally
  • Create a flag that allows files to be saved locally, otherwise default to hub
  • Improve overriding of local routines logic
  • Add description as comment in local file
  • Add tags as comment in local file
  • Check that the tags selected are valid. Do it at record time and not "stop"
  • Ensure that there鈥檚 at least 4 commands being run before stop
  • Check that tags are validated before uploading to Hub
  • Check that the sharing link works with the Hub
  • Check that title, description and tags are correctly set in the Hub

@jmaslek please check PR and if you can fix any linting and others, I'd appreciate it 馃檹馃徑

@reviewpad reviewpad bot added the feat XS Extra small feature label Aug 13, 2023
* check that routine title is valid

* more updates

* small fixes

* override local routine

* more improvements to routine logic
@reviewpad reviewpad bot added feat M Medium T-Shirt size feature and removed feat XS Extra small feature labels Aug 13, 2023
DidierRLopes and others added 4 commits August 13, 2023 17:18
* check that routine title is valid

* more updates

* small fixes

* override local routine

* more improvements to routine logic

* --debug runs .dev
* check that routine title is valid

* more updates

* small fixes

* override local routine

* more improvements to routine logic

* --debug runs .dev

* few more updates
* check that routine title is valid

* more updates

* small fixes

* override local routine

* more improvements to routine logic

* --debug runs .dev

* few more updates

* small fix
#5319)

* check that routine title is valid

* more updates

* small fixes

* override local routine

* more improvements to routine logic

* --debug runs .dev

* few more updates

* small fix

* rename BASE_URL from ultima to ULTIMA_BASE_URL

* use debug from dataclasses instead of env since env doesn't get updated

* create --dev flag that can point to .dev backend

* merge conflits

* few changes, made it actually work 馃ぃ

---------

Co-authored-by: tehcoderer <me@tehcoderer.com>
@DidierRLopes DidierRLopes marked this pull request as ready for review August 14, 2023 06:20
* check that routine title is valid

* more updates

* small fixes

* override local routine

* more improvements to routine logic

* --debug runs .dev

* few more updates

* small fix

* rename BASE_URL from ultima to ULTIMA_BASE_URL

* use debug from dataclasses instead of env since env doesn't get updated

* create --dev flag that can point to .dev backend

* merge conflits

* few changes, made it actually work 馃ぃ

* fix regex

---------

Co-authored-by: tehcoderer <me@tehcoderer.com>
@jmaslek jmaslek changed the base branch from develop to release/3.2.1 August 14, 2023 13:38
@jmaslek jmaslek merged commit 3ee60e0 into release/3.2.1 Aug 14, 2023
8 checks passed
@piiq piiq deleted the hotfix/macro-routines-to-hub branch August 28, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat M Medium T-Shirt size feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants