Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed URL for uploading to the hub #5340

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Fixed URL for uploading to the hub #5340

merged 3 commits into from
Aug 17, 2023

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Aug 17, 2023

We were calling the frontend for backend endpoints:

Also, I removed the parameter for base_url. There is no reason to have it, and the default gets set in the beginning, so if the value changes (like when we set dev mode, the parameter does not change).

@reviewpad reviewpad bot added the feat XS Extra small feature label Aug 17, 2023
@colin99d colin99d added the do not merge Label to prevent pull request merge label Aug 17, 2023
@colin99d colin99d removed the do not merge Label to prevent pull request merge label Aug 17, 2023
@jmaslek jmaslek added this pull request to the merge queue Aug 17, 2023
Merged via the queue into develop with commit f07d116 Aug 17, 2023
16 checks passed
@colin99d colin99d deleted the hotfix/makeuploadwork branch August 17, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants