Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add derivatives extension for options commands #5710

Closed
wants to merge 1,479 commits into from
Closed

Add derivatives extension for options commands #5710

wants to merge 1,479 commits into from

Conversation

the-praxs
Copy link
Contributor

@the-praxs the-praxs commented Nov 10, 2023 •
edited
Loading

Moved equity.options to derivatives.options as a separate extension.

jmaslek and others added 30 commits October 6, 2023 10:29
@jmaslek
change location
c345ca7
@jmaslek
check something
f347933
@jmaslek
add cache
6d124d3
@the-praxs
fixed auth w/@IgorWounds and @montezdesousa
a14d188
@hjoaquim
fixes for econometrics
390f9cb
@hjoaquim
Merge branch 'feature/integration-testing' into hotfix/wrong-instanti…
84c194e 
…ations
@montezdesousa
include Darren auth suggestions
b03e06d
@montezdesousa
some routers included if dev + chg hub backend var
47821e2
@montezdesousa
coverage router should not be here
bbe40da
@the-praxs
Merge branch 'feature/openbb-sdk-v4' into feature/integration-testing
60df2bc
@montezdesousa
update docker readme
65ecfd7
@montezdesousa
forgot to check auth here
59fcce4
@jmaslek
Change extension imports
71e95a5
@montezdesousa
update docstrings and readme
66f9ffd
@jmaslek
headers function wasnt being called, just referenced
39e9136
@jmaslek
relative import
ba169a8
@jmaslek
econometrics add headers everywhere
ce149aa
@IgorWounds
Fix QA
d363eac
@IgorWounds
Fix TA
494a52e
@IgorWounds
Merge
4744b58
@IgorWounds
Fix test
ea4f4a7
@IgorWounds
Fix python interface QA and TA
8eb1497
@IgorWounds
Lint
9e569eb
@IgorWounds
Cleanup
2bde8e8
@IgorWounds
Merge pull request #5531 from OpenBB-finance/hotfix/wrong-instantiations
1d906d4 
Hotfix/wrong instantiations
@IgorWounds
Change path
0874b99
@hjoaquim
Merge branch 'feature/openbb-sdk-v4' into feature/integration-testing
4302e70
@deeleeramone
make the changes and some etf models
549af38
@deeleeramone
Merge branch 'feature/openbb-sdk-v4' of https://github.com/OpenBB-fin…
63d7330 
…ance/OpenBBTerminal into feature/add-v4-standard-models
@hjoaquim
tests for command_runner
baf3bd3
@reviewpad reviewpad bot added the feat XL Extra Large feature label Nov 10, 2023
@the-praxs the-praxs added v4 PRs for v4 platform OpenBB Platform do not merge Label to prevent pull request merge labels Nov 10, 2023
@the-praxs the-praxs changed the title Add derivatives menu for options commands Add derivatives extension for options commands Nov 10, 2023
@the-praxs the-praxs requested a review from piiq November 10, 2023 23:10
@the-praxs the-praxs changed the base branch from feature/openbb-sdk-v4 to feature/economy-index-rename November 11, 2023 07:39
@the-praxs the-praxs removed the do not merge Label to prevent pull request merge label Nov 11, 2023
@the-praxs
Copy link
Contributor Author

This should be merged into #5705 before that is merged into #5225.

@piiq
Copy link
Contributor

piiq commented Nov 11, 2023

i think we'll keep options in the equity section for now. we don't have many datapoints for derivatives as a separate class and as we get those we'll introduce the menu. I'll be wrapping up the economy/index menu for now

@the-praxs
Copy link
Contributor Author

i think we'll keep options in the equity section for now. we don't have many datapoints for derivatives as a separate class and as we get those we'll introduce the menu. I'll be wrapping up the economy/index menu for now

We have futures and options so we can include both in the derivatives extension.

Base automatically changed from feature/economy-index-rename to feature/openbb-sdk-v4 November 11, 2023 17:49
@the-praxs the-praxs changed the base branch from feature/openbb-sdk-v4 to develop November 13, 2023 15:17
reviewpad[bot]
reviewpad bot suggested changes Nov 13, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

@reviewpad Reviewpad
Copy link

reviewpad bot commented Nov 13, 2023

Reviewpad Report

⚠️ Warnings

  • The pyproject.toml file has been changed. Please make sure that the files requirements.txt and requirements-full.txt do not need to be updated
  • It looks like you have files with CRLF line endings. Please make sure that all files have LF line endings

@the-praxs
Copy link
Contributor Author

Closing in favor of #5742!

@the-praxs the-praxs closed this Nov 16, 2023
@piiq piiq deleted the feature/add-derivatives branch November 17, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reviewpad reviewpad[bot] reviewpad requested changes

@IgorWounds IgorWounds Awaiting requested review from IgorWounds

@hjoaquim hjoaquim Awaiting requested review from hjoaquim

@piiq piiq Awaiting requested review from piiq

Assignees
No one assigned
Labels
feat XL Extra Large feature platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@the-praxs @piiq @jmaslek @hjoaquim @montezdesousa @IgorWounds @deeleeramone @tehcoderer @DidierRLopes