Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated API endpoint from deprecated api.coindix to api.nanoly #5848

Closed

Conversation

davidtran001
Copy link

This PR addresses issue #5631, it fixes the /crypto/defi/vaults command.

The api endpoint https://api.coindix.com/ and https://apiv2.coindix.com/ has been replaced with https://api.nanoly.com/ since coindix was renamed to nanoly last year.

Without the fix running /crypto/defi/vaults results in:
Screenshot 2023-12-01 at 11 18 44 PM

Running /crypto/defi/vaults after the fix resolves this issue:
Screenshot 2023-12-01 at 11 19 36 PM

jmaslek and others added 30 commits October 4, 2023 15:11
…-tests

Add the v4 tests to default branch
* updating showcase page

* use sdk instead
add new bot command autopost docs to docs.openbb.co

Co-authored-by: James Maslek <jmaslek11@gmail.com>
* tweaks for monetization

* fix linting issue
…finance#5503)

* fix: Modify 'load' behavior to append data to existing sheet

Details:
- Added logic to detect existing sheet and append data if present.
- There is no direct way to append on the sheet, so I am reading the sheet to get the last row number and then writing after that row number.

Resolves: OpenBB-finance#5472

* Fixed 'worksheet not found' error during export to an existing sheet

* Changes:
* Now if the sheet exists in the xlsx file it will ask the user if he
  wants to replace/append/create new sheet

---------

Co-authored-by: Danglewood <85772166+deeleeramone@users.noreply.github.com>
* Add columns to `stocks/search`

isin, cusip, figi, composite_figi, shareclass_figi

* Update test_search[False].txt

* Update test_search[True].txt

* Delete tests/openbb_terminal/stocks/cassettes/test_stocks_helper/test_search.yaml

* Create test_search.yaml

---------

Co-authored-by: Danglewood <85772166+deeleeramone@users.noreply.github.com>
* fix: Modify 'load' behavior to append data to existing sheet

Details:
- Added logic to detect existing sheet and append data if present.
- There is no direct way to append on the sheet, so I am reading the sheet to get the last row number and then writing after that row number.

Resolves: OpenBB-finance#5472

* Added --export option for exporting to a desired file in /econometrics menu

* Added a -f/--file option to provide the filename for export.
Made -t/--type and -f/--file mutually exclusive.
If -f is not given, -t is required and the filename will be generated based on the time and module.

* Revert `helper_funcs.py` to original state

* Made some arguments not required.

* Minor changes asked by @deeleeramone

* No sheet name

* black

---------

Co-authored-by: James Maslek <jmaslek11@gmail.com>
Co-authored-by: Danglewood <85772166+deeleeramone@users.noreply.github.com>
* change ultima paragraph

* remove old paragraph
In the mobile view (media max 400px ), the text line "Installation >>" appears broken into smaller segments.

Co-authored-by: James Maslek <jmaslek11@gmail.com>
* add first iteration of content for Terminal Pro

* Update index.md

* Update dashboards.md

* Update folders.md

* Update grouping.md

* Update report.md

* Update templates.md

* Update quick-start.md

* Update index.md

* Update index.md

* Update home.md

* Update news.md

* Update index.md

* Update index.md

* Update index.md

* Update data-provider.md

* Update chat-with-widget.md

* Update data-manipulation.md

* Update forecasting.md

* fix: images self closing tags

* fix: only pro visitors can see pro

* inter font

* improve SEO content and restructuring

* add new package for toggle on tutorials

* move folder around

* improve main page of each prod

* small updates and improvements

* fix logo above

* small improvement in headtitle for portfolio funcs

* fix typos from OpenAI's GPT-4

* fix _category_ json

* remove generic SEO words

* add script that generates SEO for documentation

* add missing file

* remove sdk warning message

* fix links for andrew

---------

Co-authored-by: jose-donato <zmcdonato@gmail.com>
Co-authored-by: jose-donato <43375532+jose-donato@users.noreply.github.com>
Co-authored-by: andrewkenreich <andrew.kenreich@gmail.com>
…aurus.config.js (OpenBB-finance#5627)

* typo

* pro docs tab coloring

* sidebar selection blue

* redirecting missing
…e#5658)

* fix the redirect for intro to the correct url for docs

* fix code linting

---------

Co-authored-by: James Maslek <jmaslek11@gmail.com>
* small improvement

* Fix TutorialVideo for mobile view

* main page terminal pro docs

* jose whelp

* placeholder index file that needs to be removed

* fix: fixes sidebar, removes unused index.md

* update link to api keys

* update api keys link

* fix hyperlinks in terminal helper

* fix a few more links

* fix some more links

* linter

* black linter

* improve main docs page for each product

* small refactor

* header to take to main page of product

* run OpenAI script to generate SEO for pro content

---------

Co-authored-by: jose-donato <43375532+jose-donato@users.noreply.github.com>
* OpenBB-finance#5633 adding comma every 1000

* pylint

---------

Co-authored-by: Danglewood <85772166+deeleeramone@users.noreply.github.com>
* Adding more robust special character handling to create_output_path().��Addresses OpenBB-finance#5299

* Running black linter on code to conform to OBB style guides.

---------

Co-authored-by: James Maslek <jmaslek11@gmail.com>
Co-authored-by: Danglewood <85772166+deeleeramone@users.noreply.github.com>
the-praxs and others added 27 commits November 28, 2023 21:13
…penBB-finance#5813)

* HistoricalDividends re-defined

* re-define fmp model

* add intrinio model

* re-record intrinio test

* fix integration tests

---------

Co-authored-by: Danglewood <85772166+deeleeramone@users.noreply.github.com>
* fix typo

* fix typos

* fix typo

* fix typos

* fix typos

* fix typos

* fix typo

---------

Co-authored-by: Luqman <luqazino@gmail.com>
Co-authored-by: hjoaquim <h.joaquim@campus.fct.unl.pt>
…5817)

* fix fmp insider trading

* re-capture tests

* fix intrinio test
…enBB-finance#5811)

* raise error if no api key found

* check for empty strings

* black

* fix test

* less verbose

---------

Co-authored-by: Diogo Sousa <montezdesousa@gmail.com>
Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com>
… Income (OpenBB-finance#5815)

* replace zeros with None in Balance, Cash, Income

* black

---------

Co-authored-by: Pratyush Shukla <ps4534@nyu.edu>
…enBB-finance#5801)

* set level as default tag value

* set limit to 1000

* re-record fetcher test

---------

Co-authored-by: James Maslek <jmaslek11@gmail.com>
Co-authored-by: Danglewood <85772166+deeleeramone@users.noreply.github.com>
* fix equity tests - python

* remove test for intrinio

* remove index.fred and fix tests w/@hjoaquim,@IgorWounds

* fix ultima company news model w/@hjoaquim,@IgorWounds

* re-record intrinio insider trading w/@hjoaquim,@IgorWounds

* adjust endpoint

* adjust endpoint

* adjust params

* fix equity test w/@IgorWounds

* re-record

* remove ultima test

* adding keys to the workflow

* typo

---------

Co-authored-by: Pratyush Shukla <ps4534@nyu.edu>
* debug

* debug2

* extra debug step

* Another hail mary

* add debug

* MMMMMbop

* didnt import base64

* Other tests with headers

* increase timeout to 20

---------

Co-authored-by: Pratyush Shukla <ps4534@nyu.edu>
* Fix test coverage test failing

* Fix spot rates integration test

* Apply the standardization to intrinio balance, income and cash

---------

Co-authored-by: Pratyush Shukla <ps4534@nyu.edu>
Co-authored-by: James Maslek <jmaslek11@gmail.com>
* Improve widgets library structure

* add styling to widgets library images

* black linting

* update widgets library index generator

* update border of docs image

* shift grouping Minh suggestion

* no ruff in this file

* Update chart-from-raw-data.md

* lint

* add pro to index docs

* add workflows to docs

* dunno how to spell existent lol

* navbar logo to go to root docs

* push missing bg

* backend for terminal pro repo - Andrew suggestion

* update content slightly

* no widgets-library content should be pushed, this is generated at runtime

* add Rita's vidos + review everything
* publish core and extensions

* build static

* lock openbb

* force commit package changes

---------

Co-authored-by: Henrique Joaquim <h.joaquim@campus.fct.unl.pt>
Co-authored-by: Pratyush Shukla <ps4534@nyu.edu>
…5825)

* Add verbosity to login

* Fix tests

* Add verbosity for other

* pratty=False

* docstring

---------

Co-authored-by: Diogo Sousa <montezdesousa@gmail.com>
* core readme

* mentioning query params
…penBB-finance#5829)

* Move pytest to core dev deps

* removing openbb-core from devtools

* Fix dev_install script not picking developer dependencies

---------

Co-authored-by: Henrique Joaquim <h.joaquim@campus.fct.unl.pt>
…nBB-finance#5835)

* Prevent gh-actions from publishing v3 unless explicitly asked to

* ) says: "Wait for meeeeeee!"

* Update branch name regex

* Revert release-v3 changes
* Add verbosity to login

* Fix tests

* fix dem tests baby

---------

Co-authored-by: Pratyush Shukla <ps4534@nyu.edu>
* pyproject toml and poetry.lock files

* static assets

* fix link to platform

* bump core

* 4.0.1 adjustments
* move old example notebooks to v3 folder, update loadHistoricalPriceData and add findSymbols

* Create README.md

* Update README.md

* Update README.md

* Update README.md

* Vertical diagram instead

* important classes

* core dependencies

* folder structure

* devtools

* swap order

* fix github pages deploy issue

* development index

* delete expectations for developers

* devtools

* obbject stuff

* add

* installation

* hub sync

* idk if i committed already

* add usage page for financial statements

* add link to reference page

* syntax

* numbers

* nearly --> more than

* easier to read code blocks

* codespell

* removing mention to provider

* add 'orientation' for to_dict

* info card for output user preference

* put it in a code block

* correct user_settings.json example

* syntax corrections

* fix sentence

* get rid of floating point mathc

* get rid of other floating point math

* add companion example notebook for financial statements, and new section

* historical prices usage page

* codespell

* add commitment of traders section to usage

* add a note

* codespell

* get rid of equals sign

* Cleanup docs. with @the-praxs

* install

* obbject extend

* spell

* HeadTitle thingies

* Update obbject_extensions.md

* Update obbject_extensions.md

* typo

* Update architectural_considerations.md

* point to the TET pattern

* optional vs required

* reviewing the  patterns. removed the --pre flag under the assumption this will be the final docs for the release cc @deeleeramone

* add a walkthrough

* spelling

* Add more in the introduction

* validator examples

* update Copper-to-Gold notebook example for V4

* Update README.md

* QA Caveats w @the-praxs

* info on class outputs

* merge add data sources and add data points

* disclaimer on cookiecutter

* add missing import to example

* slight syntax change

* missing code block

* missing import

* update intrinio example syntax

* intrinio syntax update

* urls

* core and provider merged

* example syntax

* grammar

* Update API banner link

* quick-fix-docs cc @minhhoang1023

* Update pip install command for v3

* remove --pre note block

* update landing image

---------

Co-authored-by: Henrique Joaquim <h.joaquim@campus.fct.unl.pt>
Co-authored-by: Luqman <luqazino@gmail.com>
Co-authored-by: James Maslek <jmaslek11@gmail.com>
Co-authored-by: Igor Radovanovic <74266147+IgorWounds@users.noreply.github.com>
Co-authored-by: montezdesousa <79287829+montezdesousa@users.noreply.github.com>
Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com>
Co-authored-by: Pratyush Shukla <ps4534@nyu.edu>
* break one table into 2

* Edit pypi readme

* remove extra ```

---------

Co-authored-by: Danglewood <85772166+deeleeramone@users.noreply.github.com>
* Google Colab Install Notebook

Adds example notebook for Google Colab install.

* Update README.md

* Update README.md

Add badge -- won't work until merged into develop

* point to develop for nb

---------

Co-authored-by: James Maslek <jmaslek11@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Dec 2, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
9 out of 10 committers have signed the CLA.

✅ the-praxs
✅ deeleeramone
✅ jmaslek
✅ piiq
✅ hjoaquim
✅ montezdesousa
✅ IgorWounds
✅ jose-donato
✅ DidierRLopes
❌ David Tran


David Tran seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@reviewpad reviewpad bot added the feat XL Extra Large feature label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XL Extra Large feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet