Reconfigure lead-off detection every ADS reset #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this was only done at initial board reset, but this state would get clobbered any time the sample rate was changed. Also, this commit bumps the firmware version to 3.1.3. Addresses OpenBCI#94.
|
Brad, this sounds great. Thanks very much for sleuthing this out. Mentioning @retiutut @conorrussomanno @produceconsumerobot @shirleyzhang867 |
|
Also mentioning @andrewjaykeller . AJ, this fixes impedance reading using the Wifi Shield, which was previously broken because of missing ADS1299 lead off setting. |
|
Conor @conorrussomanno, who will merge this Pull Request? AJ likes it, but I don't think he has write access. There is another PR from May regarding reseting an SD card flag. Looks benign. Seems like the firmware version number bump that Brad included in his PR is also a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this was only done at initial board reset, but this state would
get clobbered any time the sample rate was changed.
Also, this commit bumps the firmware version to 3.1.3.
Addresses #94.