Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W_accelerometer #73

Merged
merged 2 commits into from Dec 7, 2016
Merged

W_accelerometer #73

merged 2 commits into from Dec 7, 2016

Conversation

sunwangshu
Copy link
Contributor

@sunwangshu sunwangshu commented Dec 7, 2016

Widgetized accelerometer widget based on new template.
Live data and playback data from OpenBCI board working now.
Commented out .setFont because somehow not working here.

major next step:
live and playback from Ganglion need to be implemented.
playback from BDF needs to be implemented.

minor issues:
aesthetic improvements.
improve synthesize acc data.
vertical responsive fix.
Playback initialize buffer not empty when initialize

Widgetized accelerometer widget based on new template.
Live data and playback data from OpenBCI board working now.
Commented out .setFont because somehow not working here.

major next step:
live and playback from Ganglion need to be implemented.

minor issues:
aesthetic improvements.
integrate synthetic data.
y axis responsive fix.
Playback initialize buffer not empty when initialize
@andrewjaykeller
Copy link

this is so cool.

@andrewjaykeller
Copy link

Hey I'm worried this code will not work if the user chose to output BDF vs the original ODF.

@sunwangshu
Copy link
Contributor Author

Oh right I'm not sure how the other data format work.

@andrewjaykeller andrewjaykeller changed the base branch from master to development December 7, 2016 19:43
@andrewjaykeller
Copy link

That's ok, i can try to fix it, I was hoping to go through it with you anyway to get your helping on making it work completely. I think we should merge this.

@sunwangshu
Copy link
Contributor Author

Ok let me know if any question regarding current update and I'll try to explain as I can.

BTW I think I'll update it a little bit since Conor's using the latest version of ControlP5 and the setText() error is not a bug.

setFont is working with latest ControlP5 library (2.2.6)
Updated the ControlP5 library in the outer folder.
@sunwangshu
Copy link
Contributor Author

Reverted setText() back to original and updated ControlP5 library version.

@andrewjaykeller
Copy link

Scaling is very strange and this does not seem right. Also was text changed?
screen shot 2016-12-07 at 3 09 40 pm

@andrewjaykeller
Copy link

I'm still seeing it in the smaller config too
screen shot 2016-12-07 at 3 11 45 pm

@sunwangshu
Copy link
Contributor Author

Vertical scaling is not yet implemented as stated above. So you are seeing it as it is now. For now the functionality should be fine except I'm not sure about BDF playback.

@andrewjaykeller
Copy link

andrewjaykeller commented Dec 7, 2016

Ok re:

y axis responsive fix.

Ok so I should drag and drop this controlP5 library to test it?

@sunwangshu
Copy link
Contributor Author

Try sync this branch because I just updated the library.
Then you can drag and drop the OpenBCI_GUI_v2.0/libraries/ControlP5 into your processing libraries folder, test if the text are showing up correctly.
The header font should be looking like this:
screen shot 2016-12-07 at 3 20 46 pm

@andrewjaykeller
Copy link

Yea ok we're seeing it now. Will merge now.

@andrewjaykeller andrewjaykeller merged commit bded7e0 into development Dec 7, 2016
@andrewjaykeller andrewjaykeller deleted the W_accelerometer branch December 7, 2016 20:26
@andrewjaykeller
Copy link

I also changed your base branch and put it in development. not going to merge this with master just yet, would like to get the y scaling fixed at least.

@sunwangshu
Copy link
Contributor Author

Ok, it was based on development but anyway thanks for checking :)

@andrewjaykeller
Copy link

andrewjaykeller commented Dec 7, 2016

Yup the goal is to keep master stable and nice looking, going to dev first gives us a chance to all try and catch bugs.

Good work!

@sunwangshu
Copy link
Contributor Author

Yeahh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants