Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Functions for "Printing" Hermit Totems #13

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Add Functions for "Printing" Hermit Totems #13

merged 4 commits into from
Jun 1, 2023

Conversation

OpenBagTwo
Copy link
Owner

@OpenBagTwo OpenBagTwo commented Dec 24, 2022

Hermit Totems

This PR adds the ability to "print" the custom totems designed by u/BrazenWolf_, which the author made available for download.

Outdated info **This PR does not contain the custom totems themselves! You will need to download the resource pack from the link above!**

Because the author also published some additional totems, I made some modifications to the totem_of_undying.json in my resource pack

{
  "parent":"minecraft:item/generated",
  "textures":{
    "layer0":"minecraft:item/totem_of_undying"
  },
  "overrides":[
    {
      "predicate":{
        "custom_model_data":900
      },
      "model":"item/totem_of_undying/brazen_totem"
    },
    {
      "predicate":{
        "custom_model_data":901
      },
      "model":"item/totem_of_undying/docm77_totem"
    },
    {
      "predicate":{
        "custom_model_data":902
      },
      "model":"item/totem_of_undying/grian_totem"
    },
    {
      "predicate":{
        "custom_model_data":903
      },
      "model":"item/totem_of_undying/mumbo_totem"
    },
    {
      "predicate":{
        "custom_model_data":904
      },
      "model":"item/totem_of_undying/etho_totem"
    },
    {
      "predicate":{
        "custom_model_data":905
      },
      "model":"item/totem_of_undying/bdubs_totem"
    },
    {
      "predicate":{
        "custom_model_data":906
      },
      "model":"item/totem_of_undying/xisuma_totem"
    },
    {
      "predicate":{
        "custom_model_data":907
      },
      "model":"item/totem_of_undying/scar_totem"
    },
    {
      "predicate":{
        "custom_model_data":908
      },
      "model":"item/totem_of_undying/beef_totem"
    },
    {
      "predicate":{
        "custom_model_data":909
      },
      "model":"item/totem_of_undying/cleo_totem"
    },
    {
      "predicate":{
        "custom_model_data":910
      },
      "model":"item/totem_of_undying/cubfan_totem"
    },
    {
      "predicate":{
        "custom_model_data":911
      },
      "model":"item/totem_of_undying/hypno_totem"
    },
    {
      "predicate":{
        "custom_model_data":912
      },
      "model":"item/totem_of_undying/ijevin_totem"
    },
    {
      "predicate":{
        "custom_model_data":913
      },
      "model":"item/totem_of_undying/impulse_totem"
    },
    {
      "predicate":{
        "custom_model_data":914
      },
      "model":"item/totem_of_undying/iskal_totem"
    },
    {
      "predicate":{
        "custom_model_data":915
      },
      "model":"item/totem_of_undying/joehills_totem"
    },
    {
      "predicate":{
        "custom_model_data":916
      },
      "model":"item/totem_of_undying/keralis_totem"
    },
    {
      "predicate":{
        "custom_model_data":917
      },
      "model":"item/totem_of_undying/tango_totem"
    },
    {
      "predicate":{
        "custom_model_data":918
      },
      "model":"item/totem_of_undying/tfc_totem"
    },
    {
      "predicate":{
        "custom_model_data":919
      },
      "model":"item/totem_of_undying/welsknight_totem"
    },
    {
      "predicate":{
        "custom_model_data":920
      },
      "model":"item/totem_of_undying/xb_totem"
    },
    {
      "predicate":{
        "custom_model_data":921
      },
      "model":"item/totem_of_undying/zedaph_totem"
    },
    {
      "predicate":{
        "custom_model_data":922
      },
      "model":"item/totem_of_undying/false_totem"
    },
    {
      "predicate":{
        "custom_model_data":923
      },
      "model":"item/totem_of_undying/pearl_totem"
    },
    {
      "predicate":{
        "custom_model_data":924
      },
      "model":"item/totem_of_undying/stress_totem"
    },
    {
      "predicate":{
        "custom_model_data":925
      },
      "model":"item/totem_of_undying/gem_totem"
    },
    {
      "predicate":{
        "custom_model_data":926
      },
      "model":"item/totem_of_undying/renking_totem"
    },
    {
      "predicate":{
        "custom_model_data":927
      },
      "model":"item/totem_of_undying/grumbot_totem"
    },
    {
      "predicate":{
        "custom_model_data":928
      },
      "model":"item/totem_of_undying/impulsedwarf_totem"
    }
  ]
}

and those are the CustomModelData numbers that the commands reference.

I'll have to think about whether I want to include that file in my "Chappeau Resourcepack" or whether I want to make my numberings consistent with the original zip file.

I also need to decide what sort of documentation I should be putting in the READMEs.

@OpenBagTwo
Copy link
Owner Author

Oh, also, see the dev work in this notebook. Not only am I thinking that's probably going to be my process going forward, but the "separate functions for each base item" idea is probably good form.

@OpenBagTwo
Copy link
Owner Author

Oh hey! I just remembered I heard back from the totem creator!

Screenshot from 2023-06-01 08 26 48

@OpenBagTwo OpenBagTwo marked this pull request as ready for review June 1, 2023 13:02
@OpenBagTwo
Copy link
Owner Author

Verified that this is still working in 1.20[-rc1]

@OpenBagTwo OpenBagTwo merged commit c3f0a61 into main Jun 1, 2023
@OpenBagTwo OpenBagTwo deleted the totems branch June 1, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant