This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Don't show moderators that have the wrong currency #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjeffryes
changed the title
rmisio
suggested changes
Sep 7, 2017
js/collections/Moderators.js
Outdated
| @@ -61,8 +61,11 @@ export default class extends Collection { | |||
| // don't add excluded ids or your own id | |||
| const notExcluded = excludeList.indexOf(mod.id) === -1 && mod.id !== app.profile.id; | |||
| // don't add if not a mod or the mod data is missing | |||
| // don't add if the currency doesn't match the network | |||
| const cur = !!app.serverConfig.testnet ? 'tBTC' : 'BTC'; | |||
There was a problem hiding this comment.
Could you use app.serverConfig.cryptoCurrency to determine the currency as opposed to the testnet flag? That would make it more robust once we start handling other crypto currency values.
| @@ -98,7 +98,16 @@ export default class extends baseVw { | |||
| // don't add profiles that are not moderators. The ID list may have peerIDs | |||
| // that are out of date, and are no longer moderators. | |||
| if (eventData.profile.moderator && eventData.profile.moderatorInfo) { | |||
| this.moderatorsCol.add(eventData.profile); | |||
| // if the moderator has an invalid currency, remove them from the list | |||
| const buyerCur = !!app.serverConfig.testnet ? 'tBTC' : 'BTC'; | |||
There was a problem hiding this comment.
Same as above. Can we use app.serverConfig.cryptoCurrency?
FWIW, in my config, I'm seeing the TBTC as all caps. If you're seeing it in some cases come back as tBTC, we may need to uppercase it (and maybe log a bug asking the server to standardize it).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will check the currency accepted by a mod, and not show moderators that use the wrong currency (BTC vs. tBTC) for the network (mainnet vs. testnet).