This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Add optional asyncID query param to async API calls #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an optional query parameter allowing clients to pass in an ID used for async requests where the response is returned over websockets. The current approach of generating and returning a random ID may create a race condition causing the client to miss the response. closes #925
|
This worked as expected when I tested it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an optional query parameter allowing clients to pass in an
ID used for async requests where the response is returned over websockets.
The current approach of generating and returning a random ID may create a race
condition causing the client to miss the response.
closes #925