This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Prevent overlapping shipping rule range for quantity discount #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmisio
reviewed
Oct 24, 2017
| @@ -968,7 +968,9 @@ func validateListing(listing *pb.Listing, testnet bool) (err error) { | |||
| return fmt.Errorf("Shipping rules exceeds max of %d", MaxListItems) | |||
| } | |||
| for i, rule := range shippingOption.ShippingRules.Rules { | |||
| if (shippingOption.ShippingRules.RuleType == pb.Listing_ShippingOption_ShippingRules_FLAT_FEE_QUANTITY_RANGE || shippingOption.ShippingRules.RuleType == pb.Listing_ShippingOption_ShippingRules_FLAT_FEE_WEIGHT_RANGE) && rule.MaxRange <= rule.MinRange { | |||
| if (shippingOption.ShippingRules.RuleType == pb.Listing_ShippingOption_ShippingRules_FLAT_FEE_QUANTITY_RANGE || | |||
There was a problem hiding this comment.
rule.MaxRange <= rule.MinRange
Should we not allow min to equal max? What if you wanted to give a $1.00 flat fee shipping for a quantity of 3 items? You would set the min and max both to 3. Is that not a valid scenario?
Why are we doing this validation only for certain types? In what scenario would you want a max < min for COMBINED_SHIPPING_ADD || COMBINED_SHIPPING_SUBTRACT or any future type for that matter?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #743