Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload should tag climb/area automatically #909

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Conversation

vnugent
Copy link
Contributor

@vnugent vnugent commented Jul 12, 2023


name: Pull request
about: Create a pull request
title: ''
labels: ''
assignees: ''


What type of PR is this?(check all applicable)

  • refactor
  • feature
  • bug fix
  • documentation
  • optimization
  • other

Description

Related Issues

Issue #868

What this PR achieves

  • feat: uploading photos while viewing a climb or area will also tag that climb/area automatically
  • refactor: only notify users of errors once when there are multiple upload failures
  • refactor: use immer to simplify state mutation

Screenshots, recordings

upload-context.mov

@vercel
Copy link

vercel bot commented Jul 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
open-tacos ✅ Ready (Inspect) Visit Preview Jul 12, 2023 6:15pm

@vnugent vnugent temporarily deployed to Preview July 12, 2023 17:29 — with GitHub Actions Inactive
@vnugent vnugent marked this pull request as ready for review July 12, 2023 17:56
@vnugent vnugent temporarily deployed to Preview July 12, 2023 18:14 — with GitHub Actions Inactive
@vnugent vnugent merged commit a29cde6 into develop Jul 12, 2023
11 checks passed
@vnugent vnugent deleted the fix-868-part2 branch July 12, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant