Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Date/timestamp for ticks #175

Closed
vnugent opened this issue Oct 21, 2022 · 1 comment
Closed

Use Date/timestamp for ticks #175

vnugent opened this issue Oct 21, 2022 · 1 comment

Comments

@vnugent
Copy link
Contributor

vnugent commented Oct 21, 2022

Tick date is currently stored as YYYY-MM-DD string. We should store it in the db as Date or seconds from epoch to make it easier to visualize/sort/filter

https://github.com/OpenBeta/openbeta-graphql/blob/staging/src/db/TickTypes.ts#L8

@CocoisBuggy
Copy link
Contributor

Hey Viet, I was thinking of integrating this with another PR I'm working on but there may be a bit of nuance:

When ticks are added to the database they are not of a guaranteed origin or shape. Most of the unstructured fields in the tick object come from trying to support both MP and OB native ticks.

I have not looked too deeply into how the tick import system was made, but if the date climbed is a free text field on MP then it is not as simple as converting the field.

Someone will need to verify that MP ticks are structured in this way first, or we will need to perhaps support both date fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants