Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing Ticks/Ticks Testing #525

Closed
Downster opened this issue Sep 6, 2022 · 16 comments
Closed

Importing Ticks/Ticks Testing #525

Downster opened this issue Sep 6, 2022 · 16 comments
Labels

Comments

@Downster
Copy link
Contributor

Downster commented Sep 6, 2022

Hey there guys. I have recently added a feature that allows you to import ticks from mountain project, and tick your own climbs. All of this information should persist in our staging GraphQL database, so if you are interested in testing it out slide on over to https://graphiql-online.com/ and put in the staging endpoint https://stg-api.openbeta.io. Below I am going to list what I think should happen when using this feature, and what is to be expected from it in the future.

  • If you have not imported your ticks from Mtn Project, and have not clicked the 'Don't show again' button, you should be met with this notification when visiting a climb.
    Screen Shot 2022-09-06 at 9 08 47 AM

  • When you click show me how on the notification it should change to an input field which will only take a link in the form of a mountain project profile URL ex: https://www.mountainproject.com/user/200381859/brendan-downing

Screen Shot 2022-09-06 at 9 09 00 AM

  • After you submit your URL the modal should disappear and not show up again unless you change the ticksImported flag in the UserMetaData to false.
    Screen Shot 2022-09-06 at 9 10 31 AM

  • You should be able to tick a climb by clicking the tick this climb button, have a modal pop up, and see that information persist in the staging database
    Screen Shot 2022-09-06 at 9 11 06 AM

  • Once you tick a climb, the button should say 'View Ticks' which will lead you nowhere currently.
    Screen Shot 2022-09-06 at 9 11 34 AM

  • If you query the staging database by userID or userID and climbId, you should be able to see the respective ticks
    Screen Shot 2022-09-06 at 9 14 06 AM

  • If you run into any bugs, or have any suggestions for improvement please leave a comment here or message me on discord. In the coming weeks, I plan to add a standalone ticks page with some data visualizations that can be accessed through the user profile, and from a climb page if you have ticked that climb previously.

@Downster Downster added help wanted Extra attention is needed needs testing WIP In progress labels Sep 6, 2022
@vnugent
Copy link
Contributor

vnugent commented Sep 7, 2022

  1. Is the import button available in my profile page? I dismiss it and now can't seem to find it.
  2. Is there a way to view my ticks without using the GQL explorer?

@DarrenZLew
Copy link
Contributor

  1. Can you currently only have a single tick for a climb? MP allows multiple ticks of the same climb if you would like. i.e. you add a tick for a climb done on different days.
    image

@Downster
Copy link
Contributor Author

Downster commented Sep 7, 2022

  1. Is the import button available in my profile page? I dismiss it and now can't seem to find it.
  2. Is there a way to view my ticks without using the GQL explorer?

I did not add a button to the profile pages, and yes the ticks will be viewable once I finish the standalone ticks page. I will add a button to the profile page so we can get the modal back. I spaced on that. Adding the button to get the notification back, and a way to view individual ticks right now.

@Downster
Copy link
Contributor Author

Downster commented Sep 7, 2022

  1. Can you currently only have a single tick for a climb? MP allows multiple ticks of the same climb if you would like. i.e. you add a tick for a climb done on different days.
    image

Multiple ticks are going to be supported. I will be adding a modal that shows the current ticks of a route and within this modal you will be able to tick it again.

@Downster
Copy link
Contributor Author

Downster commented Oct 13, 2022

This feature has been pushed to our "canary branch" you can access it by putting http://stg.openbeta.io/?next=true in the URL

Please mess around with this and let me know of anything you think would be ideal to add or any bugs/improvements you find.

@vnugent
Copy link
Contributor

vnugent commented Oct 13, 2022

I was able to import without any problem. It'd be nice to have a crude "view my ticks" page to review my ticks.

Filed #576

@Downster
Copy link
Contributor Author

I was able to import without any problem. It'd be nice to have a crude "view my ticks" page to review my ticks.

Filed #576

I will hop on a view my ticks page in the coming weeks!

@vnugent vnugent mentioned this issue Oct 21, 2022
35 tasks
@vnugent
Copy link
Contributor

vnugent commented Oct 22, 2022

@itsmattsoria
Copy link

Not sure if this is the right place to log this, but I'm consistently getting an error when attempting to use the tick import feature for duplicate ticks, something like this:

"E11000 duplicate key error collection: prod-openbeta.ticks index: climbId_1_dateClimbed_1_style_1_userId_1_source_1 dup key: { climbId: "15b29c9d-e00e-5a5b-b3e7-9cb3c65d3ae4", dateClimbed: "2021-01-17", style: "Lead", userId: "c360805f-0aa6-4075-86ae-64c90bd90116", source: "MP" }"

Maybe I am just misusing the tick feature on Mountain Project, but apparently I've added a tick for each attempt/lap on routes on the same day, so I have multiple instances of ticks from the same route and same date.

@musoke
Copy link
Contributor

musoke commented Apr 18, 2023

Thank you for the report @itsmattsoria ! It looks like this is the same issue as #631? Good to see another data point confirming my hypothesis.

@vnugent
Copy link
Contributor

vnugent commented Apr 18, 2023

I think this is the root cause: OpenBeta/openbeta-graphql#175

@itsmattsoria
Copy link

@musoke sure thing, and yep, my bad.
@vnugent gotcha, thank you! 👍

@musoke
Copy link
Contributor

musoke commented Apr 18, 2023

Not a problem @itsmattsoria, I'm just happy to see progress

@actuallyyun actuallyyun unpinned this issue May 4, 2023
@vnugent
Copy link
Contributor

vnugent commented Jul 21, 2023

@itsmattsoria we recent made a fix to allow multiple ticks of the same climb on the same day (OpenBeta/openbeta-graphql#340). Can you please try again?

@itsmattsoria
Copy link

@vnugent works like a charm!

@vnugent
Copy link
Contributor

vnugent commented Jul 21, 2023

I'm closing this. FYI we're now tracking our work on a unified project board: https://github.com/orgs/OpenBeta/projects/8/views/2

If you have ideas or feature requests, please do share by filing a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

5 participants