Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build break #366

Merged
merged 2 commits into from
Dec 10, 2023
Merged

fix: build break #366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac2cc89
fix: build break
Dec 10, 2023
69836ce
don't push docker img on pr
Dec 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ on:
jobs:
# deploy to staging by commiting to api-server-deployment repo
deploy-staging:
runs-on: ubuntu-latest
if: github.ref_name == 'develop'
runs-on: ubuntu-22.04
# if: github.ref_name == 'develop'
needs: docker
steps:
- name: 'Checkout Project'
uses: 'actions/checkout@v4'
with:
fetch-depth: 1
repository: 'api-server-deployment'
repository: 'openbeta/api-server-deployment'
token: ${{ secrets.GH_DEPLOYMENT_REPO_TOKEN }}
- uses: imranismail/setup-kustomize@v2
- run: |
Expand All @@ -40,15 +40,15 @@ jobs:

# deploy to prod by commiting to api-server-deployment repo
deploy-prod:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
if: startsWith(github.ref, 'refs/tags/v')
needs: docker
steps:
- name: 'Checkout Project'
uses: 'actions/checkout@v4'
with:
fetch-depth: 1
repository: 'api-server-deployment'
repository: 'openbeta/api-server-deployment'
token: ${{ secrets.GH_DEPLOYMENT_REPO_TOKEN }}
- uses: imranismail/setup-kustomize@v2
- run: |
Expand All @@ -66,7 +66,8 @@ jobs:

# build docker image and push to registry
docker:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
if: github.event_name != 'pull_request'
needs: test
steps:
- name: 'Checkout Project'
Expand Down Expand Up @@ -106,7 +107,7 @@ jobs:

# setup basic machine to run all kinds of tests: lint, unit, integration, types
test:
runs-on: 'ubuntu-latest'
runs-on: 'ubuntu-22.04'
steps:
- name: 'Checkout Project'
uses: 'actions/checkout@v3'
Expand Down