Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #84. We now handle missing values in AMBER output files by extending the regex to parse records such as
PRESS =********
. In all cases, any missing values are interpreted asNone
. I've modified one of the files used in the AMBER parsing tests to contain a missing value in order to confirm that things work as expected. Currently this code is only applied to the Exscientia Sandpit, where the records are being used. (They are saved to disk after a run.) I'll move this into the core code when I port over the AMBER FEP code.I've also updated the plotting code to handle
None
values in time-series data with units. WhenNone
is present we filter the both the x and y data (and any associated errors) to remove data corresponding to theNone
indices in both sets, i.e. ifNone
is present in x, then we remove this value from x and the same index from y. I've not updated the logic for rawfloat
values since this isn't used internally by BioSimSpace, nor the code for plotting contours for 3D data.I've also removed some trailing whitespace that was introduced in PR #107.
devel
into this branch before issuing this pull request (e.g. by runninggit pull origin devel
): [y]Suggested reviewers:
@chryswoods