Set default-valued property to avoid issues with zero values #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lohedges
had a problem deploying
to
biosimspace-build
GitHub Actions
Error
lohedges
had a problem deploying
to
biosimspace-build
GitHub Actions
Error
lohedges
had a problem deploying
to
biosimspace-build
GitHub Actions
Error
lohedges
had a problem deploying
to
biosimspace-build
GitHub Actions
Error
lohedges
had a problem deploying
to
biosimspace-build
GitHub Actions
Error
lohedges
had a problem deploying
to
biosimspace-build
GitHub Actions
Error
|
Feel free to merge this in once sire has been merged and deployed. Code all looks good :-) |
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
|
I took the opportunity to apply a few minor tweaks related to some recent issue threads. When ready, I'll merge along side #21. |
lohedges
pushed a commit
that referenced
this pull request
Oct 12, 2023
lohedges
pushed a commit
that referenced
this pull request
Oct 12, 2023
This reverts commit f328386.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #23. It requires merging of openbiosim/sire#25 before it will work. It fixes the issue caused by assigning zero-valued properties, which no-longer have any associated units. This is achieved by initialising properties in the lambda end states using default-valued properties, which are then edited atom-by-atom.
develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]Suggested reviewers:
@chryswoods