Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #76 #77

Merged
merged 2 commits into from May 23, 2023
Merged

Fix issue #76 #77

merged 2 commits into from May 23, 2023

Conversation

lohedges
Copy link
Contributor

This PR closes #76.

(Just to note that there is still quite a lot of code duplication in the BioSimSpace.Process._openmm.py module since it has not yet been ported to the new BioSimSpace.Config configuration generator sub-package. This is because we write a full Python script, not a configuration file, so it doesn't quite fit the existing logic. I do plan on reworking things to make the code generation more modular, particularly now that the use of mixins means that things like restraints are supported by all protocols. I originally separated the protocols so that it was easier for a user to find a read the exact specification, and for us to tweak them independently while figuring out what worked best.)

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

Suggested reviewers:

@chryswoods

@lohedges lohedges added bug Something isn't working exscientia Related to work with Exscientia labels May 23, 2023
@lohedges lohedges requested a review from chryswoods May 23, 2023 10:29
@lohedges lohedges temporarily deployed to biosimspace-build May 23, 2023 10:29 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build May 23, 2023 10:29 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build May 23, 2023 10:29 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build May 23, 2023 10:29 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build May 23, 2023 10:29 — with GitHub Actions Inactive
Copy link
Contributor

@chryswoods chryswoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think you are right to duplicate code and review things later. The mixin code should make this relatively easy.

@lohedges lohedges merged commit 609aa98 into devel May 23, 2023
5 checks passed
@lohedges lohedges deleted the fix_76 branch May 23, 2023 15:12
lohedges added a commit that referenced this pull request May 23, 2023
@lohedges
Copy link
Contributor Author

I've now fixed the issue that this workaround solves in my fork of openmm here. I'll see what they say in the issue thread that I opened and raise a PR if they're happy. I'm not sure how long it would take to work it's way into a release, but it would be easy for me to revert the changes introduced in this PR at that point. This might be desirable if people want to be able to run the script in a minimal environment, e.g. without parmed, which isn't a dependency of openmm itself.

lohedges added a commit that referenced this pull request May 24, 2023
Backport fixes from PR #75 and #77 into main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exscientia Related to work with Exscientia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] rhombic dodecahedron triclinic spaces not working with OpenMM
2 participants