Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #76.
(Just to note that there is still quite a lot of code duplication in the
BioSimSpace.Process._openmm.py
module since it has not yet been ported to the newBioSimSpace.Config
configuration generator sub-package. This is because we write a full Python script, not a configuration file, so it doesn't quite fit the existing logic. I do plan on reworking things to make the code generation more modular, particularly now that the use of mixins means that things like restraints are supported by all protocols. I originally separated the protocols so that it was easier for a user to find a read the exact specification, and for us to tweak them independently while figuring out what worked best.)devel
into this branch before issuing this pull request (e.g. by runninggit pull origin devel
): [y]Suggested reviewers:
@chryswoods