New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #98 #99
Fix issue #98 #99
Conversation
Looks like there's an issue with one of our dependencies on Linux py38. Will do the usual trick of trying again in the morning before investigating further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to have them written. Also prevents a false negative if something broke in both the generator and consumer code.
Yes, worked fine today 🤷♂️ |
This PR closes #98 by updating the expected box angles used in a test to those that are now generated by the triclinic lattice reduction following this fix. While I could generate the values automatically using BioSimSpace.Box, I'd rather have them written in so that it's easier for a user to debug. (Also, these box parameters weren't generated using functionality from that sub-package.)
devel
into this branch before issuing this pull request (e.g. by runninggit pull origin devel
): [y]Suggested reviewers:
@chryswoods